Skip to content

Commit 836dc39

Browse files
ChrisRackauckasAayushSabharwal
authored andcommitted
Remove nonlinearsolve as a dep by just using the default nonlinearsolve
Should greatly improve load times when it's not needed.
1 parent ea6c022 commit 836dc39

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

Project.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,13 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
4141
MLStyle = "d8e11817-5142-5d16-987a-aa16d5891078"
4242
Moshi = "2e0e35c7-a2e4-4343-998d-7ef72827ed2d"
4343
NaNMath = "77ba4419-2d1f-58cd-9bb1-8ffee604a2e3"
44-
NonlinearSolve = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
4544
OffsetArrays = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"
4645
OrderedCollections = "bac558e1-5e72-5ebc-8fee-abe8a469f55d"
4746
OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"
4847
PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
4948
RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
5049
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
5150
RuntimeGeneratedFunctions = "7e49a35a-f44a-4d26-94aa-eba1b4ca6b47"
52-
SCCNonlinearSolve = "9dfe8606-65a1-4bb3-9748-cb89d1561431"
5351
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
5452
SciMLPublic = "431bcebd-1456-4ced-9d72-93c2757fff0b"
5553
SciMLStructures = "53ae85a6-f571-4167-b2af-e1d143709226"
@@ -198,6 +196,7 @@ REPL = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb"
198196
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
199197
ReferenceTests = "324d217c-45ce-50fc-942e-d289b448e8cf"
200198
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
199+
SCCNonlinearSolve = "9dfe8606-65a1-4bb3-9748-cb89d1561431"
201200
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
202201
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
203202
SteadyStateDiffEq = "9672c7b4-1e72-59bd-8a11-6ac3964bc41f"
@@ -207,4 +206,4 @@ Sundials = "c3572dad-4567-51f8-b174-8c6c989267f4"
207206
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
208207

209208
[targets]
210-
test = ["AmplNLWriter", "BenchmarkTools", "BoundaryValueDiffEqMIRK", "BoundaryValueDiffEqAscher", "ControlSystemsBase", "DataInterpolations", "DelayDiffEq", "NonlinearSolve", "ForwardDiff", "Ipopt", "Ipopt_jll", "ModelingToolkitStandardLibrary", "Optimization", "OptimizationOptimJL", "OptimizationMOI", "OrdinaryDiffEq", "OrdinaryDiffEqCore", "OrdinaryDiffEqDefault", "REPL", "Random", "ReferenceTests", "SafeTestsets", "StableRNGs", "Statistics", "SteadyStateDiffEq", "Test", "StochasticDiffEq", "Sundials", "StochasticDelayDiffEq", "Pkg", "JET", "OrdinaryDiffEqNonlinearSolve", "Logging", "OptimizationBase", "LinearSolve"]
209+
test = ["AmplNLWriter", "BenchmarkTools", "BoundaryValueDiffEqMIRK", "BoundaryValueDiffEqAscher", "ControlSystemsBase", "DataInterpolations", "DelayDiffEq", "NonlinearSolve", "ForwardDiff", "Ipopt", "Ipopt_jll", "ModelingToolkitStandardLibrary", "Optimization", "OptimizationOptimJL", "OptimizationMOI", "OrdinaryDiffEq", "OrdinaryDiffEqCore", "OrdinaryDiffEqDefault", "REPL", "Random", "ReferenceTests", "SafeTestsets", "StableRNGs", "Statistics", "SteadyStateDiffEq", "Test", "StochasticDiffEq", "Sundials", "StochasticDelayDiffEq", "Pkg", "JET", "OrdinaryDiffEqNonlinearSolve", "Logging", "OptimizationBase", "LinearSolve", "SCCNonlinearSolve"]

src/ModelingToolkit.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ import JuliaFormatter
5252
using MLStyle
5353
import Moshi
5454
using Moshi.Data: @data
55-
using NonlinearSolve
56-
import SCCNonlinearSolve
5755
using ImplicitDiscreteSolve
5856
using Reexport
5957
using RecursiveArrayTools

src/linearization.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
"""
2-
lin_fun, simplified_sys = linearization_function(sys::AbstractSystem, inputs, outputs; simplify = false, initialize = true, initialization_solver_alg = TrustRegion(), kwargs...)
2+
lin_fun, simplified_sys = linearization_function(sys::AbstractSystem, inputs, outputs; simplify = false, initialize = true, initialization_solver_alg = nothing, kwargs...)
33
44
Return a function that linearizes the system `sys`. The function [`linearize`](@ref) provides a higher-level and easier to use interface.
55
@@ -39,7 +39,7 @@ function linearization_function(sys::AbstractSystem, inputs,
3939
op = Dict(),
4040
p = DiffEqBase.NullParameters(),
4141
zero_dummy_der = false,
42-
initialization_solver_alg = TrustRegion(),
42+
initialization_solver_alg = nothing,
4343
autodiff = AutoForwardDiff(),
4444
eval_expression = false, eval_module = @__MODULE__,
4545
warn_initialize_determined = true,

0 commit comments

Comments
 (0)