Skip to content

Commit 86db0af

Browse files
committed
refactor: simplify parameter_dependencies and improve type inference
1 parent aa13636 commit 86db0af

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

src/systems/abstractsystem.jl

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,16 +1346,11 @@ function parameter_dependencies(sys::AbstractSystem)
13461346
pdeps = get_parameter_dependencies(sys)
13471347
systems = get_systems(sys)
13481348
# put pdeps after those of subsystems to maintain topological sorted order
1349-
if isempty(systems)
1350-
return pdeps
1351-
else
1352-
return vcat(
1353-
reduce(vcat,
1354-
[map(eq -> namespace_equation(eq, s), parameter_dependencies(s))
1355-
for s in systems]),
1356-
pdeps
1357-
)
1358-
end
1349+
namespaced_deps = mapreduce(
1350+
s -> map(eq -> namespace_equation(eq, s), parameter_dependencies(s)), vcat,
1351+
systems; init = Equation[])
1352+
1353+
return vcat(namespaced_deps, pdeps)
13591354
end
13601355

13611356
function full_parameters(sys::AbstractSystem)

0 commit comments

Comments
 (0)