Skip to content

Commit 8764c98

Browse files
committed
Just error if an equation only contains parameters (and no variables)
1 parent f7cb014 commit 8764c98

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/utils.jl

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,8 @@ function check_equations(eqs, iv)
186186

187187
for eq in eqs
188188
vars, pars = collect_vars(eq, iv)
189-
if isempty(vars)
190-
if isempty(pars)
191-
throw(ArgumentError("Equation $eq contains no variables or parameters."))
192-
else
193-
throw(ArgumentError("Equation $eq contains only parameters, but relationships between parameters should be specified with defaults or parameter_dependencies."))
194-
end
195-
end
189+
isempty(vars) && !isempty(pars) &&
190+
throw(ArgumentError("Equation $eq contains only parameters, but relationships between parameters should be specified with defaults or parameter_dependencies."))
196191
end
197192
end
198193
"""

test/odesystem.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,6 @@ eqs = [
427427
@parameters p q
428428
@test_throws ArgumentError ODESystem([p ~ q], t; name = :foo)
429429
@test_throws ArgumentError ODESystem([p ~ 1], t; name = :foo)
430-
@test_throws ArgumentError ODESystem([1 ~ 2], t; name = :foo)
431430

432431
@variables x(t)
433432
@parameters M b k

0 commit comments

Comments
 (0)