Merge pull request #1465 from SciML/myb/fix

Fix sparse jacobian from TearingState

Author: YingboMa

src/structural_transformation/utils.jl

@@ -260,7 +260,6 @@ end
 function torn_system_jacobian_sparsity(sys)
     state = get_tearing_state(sys)
     state isa TearingState || return nothing
-    s = structure(sys)
     graph = state.structure.graph
     fullvars = state.fullvars
 

src/systems/abstractsystem.jl

@@ -751,10 +751,10 @@ function Base.show(io::IO, ::MIME"text/plain", sys::AbstractSystem)
     end
     limited && print(io, "\n⋮")
 
-    if has_torn_matching(sys)
+    if has_torn_matching(sys) && has_tearing_state(sys)
         # If the system can take a torn matching, then we can initialize a tearing
         # state on it. Do so and get show the structure.
-        state = get_or_construct_tearing_state(sys)
+        state = get_tearing_state(sys)
         if state !== nothing
             Base.printstyled(io, "\nIncidence matrix:"; color=:magenta)
             show(io, incidence_matrix(state.structure.graph, Num(Sym{Real}(:×))))

src/systems/pde/pdesystem.jl

@@ -78,11 +78,11 @@ end
 function Base.getproperty(x::PDESystem, sym::Symbol)
     if sym == :indvars
         return getfield(x, :ivs)
-        depwarn("`sys.indvars` is deprecated, please use `get_ivs(sys)`", :getproperty,force=true)
+        Base.depwarn("`sys.indvars` is deprecated, please use `get_ivs(sys)`", :getproperty,force=true)
 
     elseif sym == :depvars
         return getfield(x, :dvs)
-        depwarn("`sys.depvars` is deprecated, please use `get_dvs(sys)`", :getproperty,force=true)
+        Base.depwarn("`sys.depvars` is deprecated, please use `get_dvs(sys)`", :getproperty,force=true)
 
     else
         return getfield(x, sym)

test/components.jl

@@ -66,6 +66,7 @@ eqs = [
       ]
 @named sys′ = ODESystem(eqs, t)
 @named sys_inner_outer = compose(sys′, [ground, source, rc_comp])
+@test_nowarn show(IOBuffer(), MIME"text/plain"(), sys_inner_outer)
 expand_connections(sys_inner_outer, debug=true)
 sys_inner_outer = structural_simplify(sys_inner_outer)
 @test !isempty(ModelingToolkit.defaults(sys_inner_outer))
@@ -74,7 +75,7 @@ u0 = [
       rc_comp.capacitor.p.i => 0.0
       rc_comp.resistor.v => 0.0
      ]
-prob = ODEProblem(sys_inner_outer, u0, (0, 10.0))
+prob = ODEProblem(sys_inner_outer, u0, (0, 10.0), sparse=true)
 sol_inner_outer = solve(prob, Rodas4())
 @test sol[capacitor.v] ≈ sol_inner_outer[rc_comp.capacitor.v]