Fix display error and some typos

Author: YingboMa

src/structural_transformation/StructuralTransformations.jl

@@ -39,7 +39,7 @@ using NonlinearSolve
 
 export tearing, partial_state_selection, dae_index_lowering, check_consistency
 export build_torn_function, build_observed_function, ODAEProblem
-export sorted_incidence_matrix, pantelides!, tearing_reassemble
+export sorted_incidence_matrix, pantelides!, tearing_reassemble, find_solvables!
 
 include("utils.jl")
 include("pantelides.jl")

src/structural_transformation/symbolics_tearing.jl

@@ -151,7 +151,7 @@ function tearing_reassemble(state::TearingState, var_eq_matching; simplify=false
 end
 
 function tearing(state::TearingState)
-    find_solvables!(state)
+    state.structure.solvable_graph === nothing && find_solvables!(state)
     complete!(state.structure)
     @unpack graph, solvable_graph = state.structure
     algvars = BitSet(findall(v->isalgvar(state.structure, v), 1:ndsts(graph)))

src/systems/abstractsystem.jl

@@ -715,9 +715,11 @@ function Base.show(io::IO, ::MIME"text/plain", sys::AbstractSystem)
     if has_torn_matching(sys)
         # If the system can take a torn matching, then we can initialize a tearing
         # state on it. Do so and get show the structure.
-        state = TearingState(sys)
-        Base.printstyled(io, "\nIncidence matrix:"; color=:magenta)
-        show(io, incidence_matrix(state.structure.graph, Num(Sym{Real}(:×))))
+        state = TearingState(sys; check=false)
+        if state !== nothing
+            Base.printstyled(io, "\nIncidence matrix:"; color=:magenta)
+            show(io, incidence_matrix(state.structure.graph, Num(Sym{Real}(:×))))
+        end
     end
     return nothing
 end

src/systems/systemstructure.jl

@@ -196,7 +196,7 @@ function Base.push!(ev::EquationsView, eq)
     push!(ev.ts.extra_eqs, eq)
 end
 
-function TearingState(sys; quick_cancel=false)
+function TearingState(sys; quick_cancel=false, check=true)
     sys = flatten(sys)
     ivs = independent_variables(sys)
     eqs = copy(equations(sys))
@@ -218,6 +218,9 @@ function TearingState(sys; quick_cancel=false)
 
     vars = OrderedSet()
     for (i, eq′) in enumerate(eqs)
+        if eq′.lhs isa Connection
+            check ? error("$(nameof(sys)) has unexpanded `connect` statements") : return nothing
+        end
         if _iszero(eq′.lhs)
             rhs = quick_cancel ? quick_cancel_expr(eq′.rhs) : eq′.rhs
             eq = eq′
@@ -296,9 +299,9 @@ function TearingState(sys; quick_cancel=false)
         # it could be that a variable appeared in the states, but never appeared
         # in the equations.
         algvaridx = get(var2idx, algvar, 0)
-        algvaridx == 0 && throw(InvalidSystemException("The system is missing "
-            * "an equation for $algvar."
-        ))
+        if algvaridx == 0
+            check ? throw(InvalidSystemException("The system is missing an equation for $algvar.")) : return nothing
+        end
         vartype[algvaridx] = ALGEBRAIC_VARIABLE
     end