Skip to content

Commit 9b439b7

Browse files
Merge pull request #3143 from AayushSabharwal/as/linfun-dep-p
fix: fix `linearization_function` not handling dependent parameter mapping
2 parents 8f2a9e4 + d11d98d commit 9b439b7

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

src/systems/abstractsystem.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2458,6 +2458,7 @@ function linearization_function(sys::AbstractSystem, inputs,
24582458
newps = deepcopy(sys_ps)
24592459
for (k, v) in p
24602460
if is_parameter(sys, k)
2461+
v = fixpoint_sub(v, p)
24612462
setp(sys, k)(newps, v)
24622463
end
24632464
end

test/downstream/linearize.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,12 @@ matrices = linfun([1.0], Dict(p => 3.0), 1.0)
307307
# this would be 1 if the parameter value isn't respected
308308
@test matrices.f_u[] == 3.0
309309

310+
@testset "linearization_function handles dependent values" begin
311+
@parameters q
312+
matrices = @test_nowarn linfun([1.0], Dict(p => 3q, q => 1.0), 1.0)
313+
@test matrices.f_u[] == 3.0
314+
end
315+
310316
@testset "Issue #2941" begin
311317
@variables x(t) y(t)
312318
@parameters p

0 commit comments

Comments
 (0)