Merge pull request #3367 from AayushSabharwal/as/no-destructure

refactor: default `create_bindings` to false in `build_function_wrapper`

Author: ChrisRackauckas

Project.toml

@@ -146,8 +146,8 @@ StaticArrays = "0.10, 0.11, 0.12, 1.0"
 StochasticDiffEq = "6.72.1"
 StochasticDelayDiffEq = "1.8.1"
 SymbolicIndexingInterface = "0.3.37"
-SymbolicUtils = "3.10.1"
-Symbolics = "6.27"
+SymbolicUtils = "3.14"
+Symbolics = "6.29"
 URIs = "1"
 UnPack = "0.1, 1.0"
 Unitful = "1.1"

docs/src/systems/DiscreteSystem.md

@@ -6,20 +6,20 @@
 DiscreteSystem
 ```
 
-## Composition and Accessor Functions  
-
-- `get_eqs(sys)` or `equations(sys)`: The equations that define the discrete system.  
-- `get_unknowns(sys)` or `unknowns(sys)`: The set of unknowns in the discrete system.  
-- `get_ps(sys)` or `parameters(sys)`: The parameters of the discrete system.  
-- `get_iv(sys)`: The independent variable of the discrete system
-- `discrete_events(sys)`: The set of discrete events in the discrete system.
- 
+## Composition and Accessor Functions
+
+  - `get_eqs(sys)` or `equations(sys)`: The equations that define the discrete system.
+  - `get_unknowns(sys)` or `unknowns(sys)`: The set of unknowns in the discrete system.
+  - `get_ps(sys)` or `parameters(sys)`: The parameters of the discrete system.
+  - `get_iv(sys)`: The independent variable of the discrete system
+  - `discrete_events(sys)`: The set of discrete events in the discrete system.
+
 ## Transformations
 
 ```@docs; canonical=false
 structural_simplify
 ```
- 
+
 ## Problem Constructors
 
 ```@docs; canonical=false

src/systems/codegen_utils.jl

@@ -121,7 +121,7 @@ function build_function_wrapper(sys::AbstractSystem, expr, args...; p_start = 2,
         p_end = is_time_dependent(sys) ? length(args) - 1 : length(args),
         wrap_delays = is_dde(sys), wrap_code = identity,
         add_observed = true, filter_observed = Returns(true),
-        create_bindings = true, output_type = nothing, mkarray = nothing,
+        create_bindings = false, output_type = nothing, mkarray = nothing,
         wrap_mtkparameters = true, extra_assignments = Assignment[], kwargs...)
     isscalar = !(expr isa AbstractArray || symbolic_type(expr) == ArraySymbolic())
     # filter observed equations