Merge pull request #2983 from AayushSabharwal/as/use-union-false

refactor: default to `use_union = false` for `ODEProblem`s

Author: ChrisRackauckas

ext/MTKChainRulesCoreExt.jl

@@ -6,7 +6,8 @@ import ChainRulesCore: NoTangent
 
 function ChainRulesCore.rrule(::Type{MTK.MTKParameters}, tunables, args...)
     function mtp_pullback(dt)
-        (NoTangent(), dt.tunable[1:length(tunables)], ntuple(_ -> NoTangent(), length(args))...)
+        (NoTangent(), dt.tunable[1:length(tunables)],
+            ntuple(_ -> NoTangent(), length(args))...)
     end
     MTK.MTKParameters(tunables, args...), mtp_pullback
 end

src/systems/diffeqs/abstractodesystem.jl

@@ -772,7 +772,7 @@ function process_DEProblem(constructor, sys::AbstractODESystem, u0map, parammap;
         linenumbers = true, parallel = SerialForm(),
         eval_expression = false,
         eval_module = @__MODULE__,
-        use_union = true,
+        use_union = false,
         tofloat = true,
         symbolic_u0 = false,
         u0_constructor = identity,

src/systems/jumps/jumpsystem.jl

@@ -446,7 +446,7 @@ oprob = ODEProblem(complete(js), u₀map, tspan, parammap)
 """
 function DiffEqBase.ODEProblem(sys::JumpSystem, u0map, tspan::Union{Tuple, Nothing},
         parammap = DiffEqBase.NullParameters();
-        use_union = true,
+        use_union = false,
         eval_expression = false,
         eval_module = @__MODULE__,
         kwargs...)

test/extensions/ad.jl

@@ -8,15 +8,13 @@ using SciMLSensitivity
 
 @variables x(t)[1:3] y(t)
 @parameters p[1:3, 1:3] q
-eqs = [
-         D(x) ~ p * x
-         D(y) ~ sum(p) + q * y
-]
+eqs = [D(x) ~ p * x
+       D(y) ~ sum(p) + q * y]
 u0 = [x => zeros(3),
-      y => 1.]
+    y => 1.0]
 ps = [p => zeros(3, 3),
-    q => 1.]
-tspan = (0., 10.)
+    q => 1.0]
+tspan = (0.0, 10.0)
 @mtkbuild sys = ODESystem(eqs, t)
 prob = ODEProblem(sys, u0, tspan, ps)
 sol = solve(prob, Tsit5())