fix: fix discrete callback condition with array variable

Author: AayushSabharwal

src/systems/callbacks.jl

@@ -435,7 +435,7 @@ end
 """
     compile_condition(cb::SymbolicDiscreteCallback, sys, dvs, ps; expression, kwargs...)
 
-Returns a function `condition(u,p,t)` returning the `condition(cb)`.
+Returns a function `condition(u,t,integrator)` returning the `condition(cb)`.
 
 Notes
 
@@ -456,7 +456,8 @@ function compile_condition(cb::SymbolicDiscreteCallback, sys, dvs, ps;
     end
     expr = build_function(
         condit, u, t, p...; expression = Val{true},
-        wrap_code = condition_header(sys) .∘ wrap_array_vars(sys, condit; dvs, ps) .∘
+        wrap_code = condition_header(sys) .∘
+                    wrap_array_vars(sys, condit; dvs, ps, inputs = true) .∘
                     wrap_parameter_dependencies(sys, !(condit isa AbstractArray)),
         kwargs...)
     if expression == Val{true}

test/symbolic_events.jl

@@ -988,3 +988,24 @@ end
     prob = ODEProblem(pend, [x => 1], (0.0, 3.0), guesses = [y => x])
     @test all(≈(0.0; atol = 1e-9), solve(prob, Rodas5())[[x, y]][end])
 end
+
+@test "Issue#3154 Array variable in discrete condition" begin
+    @mtkmodel DECAY begin
+        @parameters begin
+            unrelated[1:2] = zeros(2)
+            k = 0.0
+        end
+        @variables begin
+            x(t) = 10.0
+        end
+        @equations begin
+            D(x) ~ -k * x
+        end
+        @discrete_events begin
+            (t == 1.0) => [k ~ 1.0]
+        end
+    end
+    @mtkbuild decay = DECAY()
+    prob = ODEProblem(decay, [], (0.0, 10.0), [])
+    @test_nowarn solve(prob, Tsit5(), tstops = [1.0])
+end