Skip to content

Commit b0241a8

Browse files
committed
Better instream expansion diagnostics
1 parent 3fd7519 commit b0241a8

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

src/systems/connectors.jl

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -348,10 +348,9 @@ end
348348
function expand_connections(sys::AbstractSystem; debug=false, tol=1e-10)
349349
sys, csets = generate_connection_set(sys)
350350
ceqs, instream_csets = generate_connection_equations_and_stream_connections(csets)
351-
additional_eqs = Equation[]
352351
_sys = expand_instream(instream_csets, sys; debug=debug, tol=tol)
353352
sys = flatten(sys, true)
354-
@set! sys.eqs = [equations(_sys); ceqs; additional_eqs]
353+
@set! sys.eqs = [equations(_sys); ceqs]
355354
end
356355

357356
function unnamespace(root, namespace)
@@ -405,7 +404,7 @@ function expand_instream(csets::AbstractVector{<:ConnectionSet}, sys::AbstractSy
405404
end
406405
end
407406
if debug
408-
@show ex idx_in_set ConnectionSet(cset)
407+
@info "Expanding at [$idx_in_set]" ex ConnectionSet(cset)
409408
@show n_inners, n_outers
410409
end
411410
if n_inners == 1 && n_outers == 0
@@ -493,15 +492,22 @@ function expand_instream(csets::AbstractVector{<:ConnectionSet}, sys::AbstractSy
493492
end
494493
end
495494

496-
if debug
495+
subed_eqs = substitute(instream_eqs, sub)
496+
if debug && !(isempty(csets) && isempty(additional_eqs) && isempty(instream_eqs))
497+
println("======================================")
497498
@info "Additional equations" csets
498-
@show additional_eqs
499+
display(additional_eqs)
500+
println("======================================")
499501
println("Substitutions")
500502
display(sub)
503+
println("======================================")
504+
println("Substituted equations")
505+
foreach(i->println(instream_eqs[i] => subed_eqs[i]), eachindex(subed_eqs))
506+
println("======================================")
501507
end
502508

503509
@set! sys.systems = []
504-
@set! sys.eqs = [get_eqs(sys); eqs; substitute(instream_eqs, sub); additional_eqs]
510+
@set! sys.eqs = [get_eqs(sys); eqs; subed_eqs; additional_eqs]
505511
sys
506512
end
507513

0 commit comments

Comments
 (0)