Fix bugs in tests, ensure that constant test is run & remove leftover debugging statements.

Author: lamorton

src/structural_transformation/codegen.jl

@@ -188,7 +188,6 @@ function gen_nlsolve!(is_not_prepended_assignment, eqs, vars, u0map::AbstractDic
     fname = gensym("fun")
     # f is the function to find roots on
     funex = isscalar ? rhss[1] : MakeArray(rhss, SVector)
-    @show funex
     pre = get_preprocess_constants(funex)
     f = Func([DestructuredArgs(vars, inbounds = !checkbounds)
               DestructuredArgs(params, inbounds = !checkbounds)],

src/systems/optimization/optimizationsystem.jl

@@ -390,7 +390,6 @@ function OptimizationProblemExpr{iip}(sys::OptimizationSystem, u0,
         [Symbol(_p) => p[i] for (i, _p) in enumerate(ps)]...,
     ]
     rep_pars_vals!(obj_expr, pairs_arr)
-    @show sys.constraints
     if length(sys.constraints) > 0
         @named cons_sys = NonlinearSystem(sys.constraints, dvs, ps)
         cons = generate_function(cons_sys, checkbounds = checkbounds,

test/constants.jl

@@ -12,7 +12,7 @@ eqs = [D(x) ~ a]
 prob = ODEProblem(sys, [0], [0.0, 1.0], [])
 sol = solve(prob, Tsit5())
 
-newsys = eliminate_constants(sys)
+newsys = MT.eliminate_constants(sys)
 @test isequal(equations(newsys), [D(x) ~ 1])
 
 # Test structural_simplify substitutions & observed values

test/funcaffect.jl

@@ -122,7 +122,7 @@ i8 = findfirst(==(8.0), sol[:t])
 ctx = [0]
 function affect4!(integ, u, p, ctx)
     ctx[1] += 1
-    @test u.resistor₊v == h
+    @test u.resistor₊v == 1
 end
 s1 = compose(ODESystem(Equation[], t, [], [], name = :s1,
                        discrete_events = 1.0 => (affect4!, [resistor.v], [], ctx)),

test/runtests.jl

@@ -46,6 +46,6 @@ println("Last test requires gcc available in the path!")
 @safetestset "Modelingtoolkitize Test" begin include("modelingtoolkitize.jl") end
 @safetestset "OptimizationSystem Test" begin include("optimizationsystem.jl") end
 @safetestset "FuncAffect Test" begin include("funcaffect.jl") end
-
+@safetestset "Constants Test" begin include("constants.jl") end
 # Reference tests go Last
 @safetestset "Latexify recipes Test" begin include("latexify.jl") end