Skip to content

Commit b477f73

Browse files
committed
Add two TODOs
1 parent 15c44d5 commit b477f73

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/systems/nonlinear/nonlinearsystem.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,8 @@ function calculate_jacobian(sys::NonlinearSystem; sparse = false, simplify = fal
194194
end
195195

196196
# observed equations may depend on unknowns, so substitute them in first
197+
# TODO: must do the same fix in e.g. calculate_hessian?
198+
# TODO: rather keep observed derivatives unexpanded, like "Differential(obs)(expr)"?
197199
obs = map(eq -> eq.lhs => eq.rhs, observed(sys))
198200
rhs = map(eq -> substitute(eq.rhs, obs), equations(sys))
199201
vals = [dv for dv in unknowns(sys)]

0 commit comments

Comments
 (0)