add check

Author: vyudu

src/systems/diffeqs/odesystem.jl

@@ -202,6 +202,7 @@ struct ODESystem <: AbstractODESystem
             check_parameters(ps, iv)
             check_equations(deqs, iv)
             check_equations(equations(cevents), iv)
+            check_var_types(ODESystem, dvs)
         end
         if checks == true || (checks & CheckUnits) > 0
             u = __get_unit_type(dvs, ps, iv)

src/systems/diffeqs/sdesystem.jl

@@ -170,6 +170,7 @@ struct SDESystem <: AbstractODESystem
             check_parameters(ps, iv)
             check_equations(deqs, iv)
             check_equations(neqs, dvs)
+            check_var_types(SDESystem, dvs)
             if size(neqs, 1) != length(deqs)
                 throw(ArgumentError("Noise equations ill-formed. Number of rows must match number of drift equations. size(neqs,1) = $(size(neqs,1)) != length(deqs) = $(length(deqs))"))
             end

src/systems/discrete_system/discrete_system.jl

@@ -122,6 +122,7 @@ struct DiscreteSystem <: AbstractTimeDependentSystem
             check_independent_variables([iv])
             check_variables(dvs, iv)
             check_parameters(ps, iv)
+            check_var_types(DiscreteSystem, dvs)
         end
         if checks == true || (checks & CheckUnits) > 0
             u = __get_unit_type(dvs, ps, iv)

src/systems/jumps/jumpsystem.jl

@@ -147,6 +147,7 @@ struct JumpSystem{U <: ArrayPartition} <: AbstractTimeDependentSystem
             check_independent_variables([iv])
             check_variables(unknowns, iv)
             check_parameters(ps, iv)
+            check_var_types(JumpSystem, unknowns)
         end
         if checks == true || (checks & CheckUnits) > 0
             u = __get_unit_type(unknowns, ps, iv)

src/systems/nonlinear/nonlinearsystem.jl

@@ -115,6 +115,9 @@ struct NonlinearSystem <: AbstractTimeIndependentSystem
             tearing_state = nothing, substitutions = nothing,
             complete = false, index_cache = nothing, parent = nothing,
             isscheduled = false; checks::Union{Bool, Int} = true)
+        if checks == true || (checks & CheckComponents) > 0
+            check_var_types(NonlinearSystem, unknowns)
+        end
         if checks == true || (checks & CheckUnits) > 0
             u = __get_unit_type(unknowns, ps)
             check_units(u, eqs)

src/systems/optimization/optimizationsystem.jl

@@ -73,6 +73,9 @@ struct OptimizationSystem <: AbstractOptimizationSystem
             gui_metadata = nothing, complete = false, index_cache = nothing, parent = nothing,
             isscheduled = false;
             checks::Union{Bool, Int} = true)
+        if checks == true || (checks & CheckComponents) > 0
+            check_var_types(OptimizationSystem, unknowns)
+        end
         if checks == true || (checks & CheckUnits) > 0
             u = __get_unit_type(unknowns, ps)
             unwrap(op) isa Symbolic && check_units(u, op)

src/systems/pde/pdesystem.jl

@@ -102,6 +102,9 @@ struct PDESystem <: ModelingToolkit.AbstractMultivariateSystem
             checks::Union{Bool, Int} = true,
             description = "",
             name)
+        if checks == true || (checks & CheckComponents) > 0
+            check_var_types(PDESystem, dvs)
+        end
         if checks == true || (checks & CheckUnits) > 0
             u = __get_unit_type(dvs, ivs, ps)
             check_units(u, eqs)

src/utils.jl

@@ -155,6 +155,14 @@ function check_variables(dvs, iv)
     end
 end
 
+function check_var_types(sys_type::Type{T}, dvs) where T <: AbstractSystem
+    any(u -> !(symtype(u) <: Number), dvs) && error("The type of unknown variables must be a numeric type.")
+    if sys_type == ODESystem || sys_type == SDESystem || sys_type == PDESystem
+        any(u -> !(symtype(u) <: Float), dvs) && error("The type of unknown variables for an SDESystem, PDESystem, or ODESystem must be a float.")
+    end
+    nothing
+end
+
 function check_lhs(eq::Equation, op, dvs::Set)
     v = unwrap(eq.lhs)
     _iszero(v) && return
@@ -1182,3 +1190,4 @@ function guesses_from_metadata!(guesses, vars)
         guesses[vars[i]] = varguesses[i]
     end
 end
+