refactor: deprecate structural_simplify and @mtkbuild

Author: AayushSabharwal

src/ModelingToolkit.jl

@@ -288,7 +288,7 @@ export alias_elimination, flatten
 export connect, domain_connect, @connector, Connection, AnalysisPoint, Flow, Stream,
        instream
 export initial_state, transition, activeState, entry, ticksInState, timeInState
-export @component, @mtkmodel, @mtkcompile
+export @component, @mtkmodel, @mtkcompile, @mtkbuild
 export isinput, isoutput, getbounds, hasbounds, getguess, hasguess, isdisturbance,
        istunable, getdist, hasdist,
        tunable_parameters, isirreducible, getdescription, hasdescription,
@@ -305,7 +305,7 @@ export independent_variable, equations, controls, observed, full_equations, jump
        brownians
 export initialization_equations, guesses, defaults, parameter_dependencies, hierarchy
 export mtkcompile, expand_connections, linearize, linearization_function,
-       LinearizationProblem
+       LinearizationProblem, structural_simplify
 export solve
 export Pre
 

src/systems/abstractsystem.jl

@@ -2491,6 +2491,13 @@ macro mtkcompile(exprs...)
     end)
 end
 
+macro mtkbuild(exprs...)
+    return quote
+        Base.depwarn("`@mtkbuild` is deprecated. Use `@mtkcompile` instead.", :mtkbuild)
+        @mtkcompile $(exprs...)
+    end |> esc
+end
+
 """
     debug_system(sys::AbstractSystem; functions = [log, sqrt, (^), /, inv, asin, acos], error_nonfinite = true)
 

src/systems/systems.jl

@@ -158,6 +158,10 @@ function __mtkcompile(sys::AbstractSystem; simplify = false,
     end
 end
 
+@deprecate structural_simplify(sys; kwargs...) mtkcompile(sys; kwargs...)
+@deprecate structural_simplify(sys, io; kwargs...) mtkcompile(
+    sys; inputs = io[1], outputs = io[2], kwargs...)
+
 function simplify_optimization_system(sys::System; split = true, kwargs...)
     sys = flatten(sys)
     cons = constraints(sys)

test/structural_transformation/utils.jl

@@ -436,3 +436,10 @@ end
         @test integ.ps[p] ≈ 3.0
     end
 end
+
+@testset "Deprecated `structural_simplify` and `@mtkbuild`" begin
+    @variables x(t)
+    @test_deprecated @mtkbuild sys = System([D(x) ~ x], t)
+    @named sys = System([D(x) ~ x], t)
+    @test_deprecated structural_simplify(sys)
+end