Merge pull request #3113 from AayushSabharwal/as/fix-vars

fix: make `vars` search through arrays of symbolics

Author: ChrisRackauckas

src/utils.jl

@@ -385,6 +385,12 @@ function vars!(vars, O; op = Differential)
     if isvariable(O)
         return push!(vars, O)
     end
+    if symbolic_type(O) == NotSymbolic() && O isa AbstractArray
+        for arg in O
+            vars!(vars, arg; op)
+        end
+        return vars
+    end
     !iscall(O) && return vars
 
     operation(O) isa op && return push!(vars, O)

test/variable_utils.jl

@@ -1,5 +1,5 @@
 using ModelingToolkit, Test
-using ModelingToolkit: value
+using ModelingToolkit: value, vars
 using SymbolicUtils: <ₑ
 @parameters α β δ
 expr = (((1 / β - 1) + δ) / α)^(1 / (α - 1))
@@ -33,3 +33,11 @@ aov = ModelingToolkit.collect_applied_operators(eq, Differential)
 
 ts = collect_ivs([eq])
 @test ts == Set([t])
+
+@testset "vars searching through array of symbolics" begin
+    fn(x, y) = sum(x) + y
+    @register_symbolic fn(x::AbstractArray, y)
+    @variables x y z
+    res = vars(fn([x, y], z))
+    @test length(res) == 3
+end