Merge pull request #886 from SciML/myb/lineq

Add `iszero` check in linear equation detection

Author: YingboMa

Project.toml

@@ -1,7 +1,7 @@
 name = "ModelingToolkit"
 uuid = "961ee093-0014-501f-94e3-6117800e7a78"
 authors = ["Chris Rackauckas <[email protected]>"]
-version = "5.13.1"
+version = "5.13.2"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/systems/systemstructure.jl

@@ -194,7 +194,7 @@ function find_linear_equations(sys)
             c = expand_derivatives(Differential(var)(term), false)
             # test if `var` is linear in `eq`.
             if !(c isa Symbolic) && c isa Number
-                if isinteger(c)
+                if isinteger(c) && !iszero(c)
                     c = convert(Integer, c)
                     linear_term += c * var
                     push!(coeffs, c)

test/reduction.jl

@@ -191,3 +191,10 @@ reducedsol = solve(nlprob, NewtonRaphson())
 residual = fill(100.0, length(states(reducedsys)))
 nlprob.f(residual, reducedsol.u, pp)
 @test all(x->abs(x) < 1e-5, residual)
+
+N = 5
+@variables xs[1:N]
+A = reshape(1:N^2, N, N)
+eqs = xs .~ A * xs
+sys′ = NonlinearSystem(eqs, xs, [])
+sys = structural_simplify(sys′)