Fix a few tests and printing

Author: YingboMa

src/systems/abstractsystem.jl

@@ -392,9 +392,13 @@ function (f::AbstractSysToExpr)(O)
     return build_expr(:call, Any[operation(O); f.(arguments(O))])
 end
 
-function Base.show(io::IO, sys::AbstractSystem)
+function Base.show(io::IO, ::MIME"text/plain", sys::AbstractSystem)
     eqs = equations(sys)
-    Base.printstyled(io, "Model $(nameof(sys)) with $(length(eqs)) equations\n"; bold=true)
+    if eqs isa AbstractArray
+        Base.printstyled(io, "Model $(nameof(sys)) with $(length(eqs)) equations\n"; bold=true)
+    else
+        Base.printstyled(io, "Model $(nameof(sys))\n"; bold=true)
+    end
     # The reduced equations are usually very long. It's not that useful to print
     # them.
     #Base.print_matrix(io, eqs)

src/systems/optimization/optimizationsystem.jl

@@ -156,8 +156,8 @@ function DiffEqBase.OptimizationProblem{iip}(sys::OptimizationSystem, u0,
     defs = defaults(sys)
     u0 = varmap_to_vars(u0,dvs; defaults=defs)
     p = varmap_to_vars(parammap,ps; defaults=defs)
-    lb = varmap_to_vars(lb,dvs)
-    ub = varmap_to_vars(ub,dvs)
+    lb = varmap_to_vars(lb,dvs; check=false)
+    ub = varmap_to_vars(ub,dvs; check=false)
     OptimizationProblem{iip}(_f,u0,p;lb=lb,ub=ub,kwargs...)
 end
 

src/systems/pde/pdesystem.jl

@@ -60,14 +60,14 @@ end
 Base.getproperty(x::PDESystem, sym::Symbol) = getfield(x, sym)
 
 Base.summary(prob::PDESystem) = string(nameof(typeof(prob)))
-function Base.show(io::IO, sys::PDESystem)
+function Base.show(io::IO, ::MIME"text/plain", sys::PDESystem)
     println(io,summary(sys))
     println(io,"Equations: ", get_eqs(sys))
     println(io,"Boundary Conditions: ", get_bcs(sys))
     println(io,"Domain: ", get_domain(sys))
     println(io,"Dependent Variables: ", get_depvars(sys))
     println(io,"Independent Variables: ", get_indvars(sys))
     println(io,"Parameters: ", get_ps(sys))
-    println(io,"Default Parameter Values", get_defaults(sys))
+    print(io,"Default Parameter Values", get_defaults(sys))
     return nothing
 end

src/variables.jl

@@ -10,11 +10,11 @@ Takes a list of pairs of `variables=>values` and an ordered list of variables
 and creates the array of values in the correct order with default values when
 applicable.
 """
-function varmap_to_vars(varmap, varlist; defaults=Dict())
+function varmap_to_vars(varmap, varlist; defaults=Dict(), check=true)
     # Edge cases where one of the arguments is effectively empty.
     if varmap isa DiffEqBase.NullParameters || varmap === nothing || isempty(varmap)
         if isempty(defaults)
-            isempty(varlist) || throw_missingvars(varlist)
+            check && (isempty(varlist) || throw_missingvars(varlist))
             return nothing
         else
             varmap = Dict()
@@ -28,7 +28,7 @@ function varmap_to_vars(varmap, varlist; defaults=Dict())
     if eltype(varmap) <: Pair # `varmap` is a dict or an array of pairs
         varmap = todict(varmap)
         rules = Dict(varmap)
-        vals = _varmap_to_vars(varmap, varlist; defaults=defaults)
+        vals = _varmap_to_vars(varmap, varlist; defaults=defaults, check=check)
     else # plain array-like initialization
         vals = varmap
     end
@@ -42,7 +42,7 @@ function varmap_to_vars(varmap, varlist; defaults=Dict())
     end
 end
 
-function _varmap_to_vars(varmap::Dict, varlist; defaults=Dict())
+function _varmap_to_vars(varmap::Dict, varlist; defaults=Dict(), check=false)
     varmap = merge(defaults, varmap) # prefers the `varmap`
     varmap = Dict(Symbolics.diff2term(value(k))=>value(varmap[k]) for k in keys(varmap))
     # resolve symbolic parameter expressions
@@ -53,7 +53,7 @@ function _varmap_to_vars(varmap::Dict, varlist; defaults=Dict())
     T = Base.isconcretetype(T′) ? T′ : Base.promote_typeof(values(varmap)...)
     out = Vector{T}(undef, length(varlist))
     missingvars = setdiff(varlist, keys(varmap))
-    isempty(missingvars) || throw_missingvars(missingvars)
+    check && (isempty(missingvars) || throw_missingvars(missingvars))
 
     for (i, var) in enumerate(varlist)
         out[i] = varmap[var]

test/sdesystem.jl

@@ -29,7 +29,7 @@ solexpr = solve(eval(probexpr),SRIW1(),seed=1)
 @test all(x->x==0,Array(sol-solexpr))
 
 # Test no error
-SDEProblem(de,nothing,nothing,SciMLBase.NullParameters())
+@test_nowarn SDEProblem(de,zeros(3),(0, 10.0),zeros(3))
 
 noiseeqs_nd = [0.01*x 0.01*x*y 0.02*x*z
                σ      0.01*y   0.02*x*z