Merge pull request #1237 from SciML/myb/fix3

Fast checking

Author: YingboMa

Project.toml

@@ -72,7 +72,7 @@ SciMLBase = "1.3"
 Setfield = "0.7"
 SpecialFunctions = "0.7, 0.8, 0.9, 0.10, 1.0"
 StaticArrays = "0.10, 0.11, 0.12, 1.0"
-SymbolicUtils = "0.12, 0.13"
+SymbolicUtils = "0.13.4"
 Symbolics = "3.1"
 UnPack = "0.1, 1.0"
 Unitful = "1.1"

src/systems/diffeqs/odesystem.jl

@@ -125,7 +125,7 @@ function ODESystem(
         Base.depwarn("`default_u0` and `default_p` are deprecated. Use `defaults` instead.", :ODESystem, force=true)
     end
     defaults = todict(defaults)
-    defaults = Dict(value(k) => value(v) for (k, v) in pairs(defaults))
+    defaults = Dict{Any,Any}(value(k) => value(v) for (k, v) in pairs(defaults))
 
     iv′ = value(scalarize(iv))
     dvs′ = value.(scalarize(dvs))

src/systems/nonlinear/nonlinearsystem.jl

@@ -85,7 +85,7 @@ function NonlinearSystem(eqs, states, ps;
     end
     jac = RefValue{Any}(Matrix{Num}(undef, 0, 0))
     defaults = todict(defaults)
-    defaults = Dict(value(k) => value(v) for (k, v) in pairs(defaults))
+    defaults = Dict{Any,Any}(value(k) => value(v) for (k, v) in pairs(defaults))
 
     states = collect(states)
     states, ps = value.(states), value.(ps)

src/utils.jl

@@ -216,7 +216,7 @@ function check_operator_variables(eq, op::Type, expr=eq.rhs)
     if operation(expr) isa op
         throw_invalid_operator(expr, eq, op)
     end
-    foreach(expr -> check_operator_variables(eq, op, expr), arguments(expr))
+    foreach(expr -> check_operator_variables(eq, op, expr), SymbolicUtils.unsorted_arguments(expr))
 end
 
 isdifferential(expr) = istree(expr) && operation(expr) isa Differential