Merge pull request #1869 from SciML/myb/io

Only force unbound causal inputs to be states

Author: YingboMa

src/variables.jl

@@ -31,7 +31,9 @@ setoutput(x, v) = setmetadata(x, VariableOutput, v)
 setio(x, i, o) = setoutput(setinput(x, i), o)
 isinput(x) = isvarkind(VariableInput, x)
 isoutput(x) = isvarkind(VariableOutput, x)
-isirreducible(x) = isvarkind(VariableIrreducible, x) || isinput(x)
+# Before the solvability check, we already have handled IO varibales, so
+# irreducibility is independent from IO.
+isirreducible(x) = isvarkind(VariableIrreducible, x)
 state_priority(x) = convert(Float64, getmetadata(x, VariableStatePriority, 0.0))::Float64
 
 """

test/input_output_handling.jl

@@ -301,3 +301,20 @@ m_outputs = [y₂]
 sys_simp, input_idxs = structural_simplify(sys, (; inputs = m_inputs, outputs = m_outputs))
 @test isequal(states(sys_simp), collect(x[1:2]))
 @test length(input_idxs) == 2
+
+# https://github.com/SciML/ModelingToolkit.jl/issues/1577
+@parameters t
+@named c = Constant(; k = 2)
+@named gain = Gain(1;)
+@named int = Integrator(; k = 1)
+@named fb = Feedback(;)
+@named model = ODESystem([
+                             connect(c.output, fb.input1),
+                             connect(fb.input2, int.output),
+                             connect(fb.output, gain.input),
+                             connect(gain.output, int.input),
+                         ],
+                         t,
+                         systems = [int, gain, c, fb])
+sys = structural_simplify(model)
+@test length(states(sys)) == length(equations(sys)) == 1