Merge pull request #1427 from SciML/myb/fix

Handle the trivial case of dependency chasing

Author: YingboMa

src/structural_transformation/codegen.jl

@@ -104,16 +104,21 @@ function gen_nlsolve!(is_not_prepended_assignment, eqs, vars, u0map::AbstractDic
 
     # Compute necessary assignments for the nlsolve expr
     init_assignments = [var2assignment[p] for p in paramset if haskey(var2assignment, p)]
-    tmp = [init_assignments]
-    # `deps[init_assignments]` gives the dependency of `init_assignments`
-    while true
-        next_assignments = reduce(vcat, deps[init_assignments])
-        isempty(next_assignments) && break
-        init_assignments = next_assignments
-        push!(tmp, init_assignments)
+    if isempty(init_assignments)
+        needed_assignments_idxs = Int[]
+        needed_assignments = similar(assignments, 0)
+    else
+        tmp = [init_assignments]
+        # `deps[init_assignments]` gives the dependency of `init_assignments`
+        while true
+            next_assignments = reduce(vcat, deps[init_assignments])
+            isempty(next_assignments) && break
+            init_assignments = next_assignments
+            push!(tmp, init_assignments)
+        end
+        needed_assignments_idxs = reduce(vcat, unique(reverse(tmp)))
+        needed_assignments = assignments[needed_assignments_idxs]
     end
-    needed_assignments_idxs = reduce(vcat, unique(reverse(tmp)))
-    needed_assignments = assignments[needed_assignments_idxs]
 
     # Compute `params`. They are like enclosed variables
     rhsvars = [ModelingToolkit.vars(r.rhs) for r in needed_assignments]

test/structural_transformation/tearing.jl

@@ -192,3 +192,36 @@ sol2 = solve(ODEProblem{false}(
 
 @test sol1[y, :] == sol1[x, :]
 @test (@. sin(sol1[z, :]) + sol1[y, :]) ≈ pr * sol1.t atol=1e-5
+
+# 1426
+function Translational_Mass(;name, m = 1.0)
+    sts = @variables s(t) v(t) a(t)
+    ps = @parameters m=m
+    D = Differential(t)
+    eqs = [
+           D(s) ~ v
+           D(v) ~ a
+           m*a ~ 0.0
+          ]
+    ODESystem(eqs, t, sts, ps; name=name)
+end
+
+m = 1.0
+@named mass = Translational_Mass(m=m)
+
+ms_eqs = []
+
+@named _ms_model = ODESystem(ms_eqs, t)
+@named ms_model = compose(_ms_model,
+                          [mass])
+
+# Mass starts with velocity = 1
+u0 = [
+      mass.s => 0.0
+      mass.v => 1.0
+     ]
+
+sys = structural_simplify(ms_model)
+prob_complex = ODAEProblem(sys, u0, (0, 1.0))
+sol = solve(prob_complex, Tsit5())
+@test all(sol[mass.v] .== 1)