Merge remote-tracking branch 'origin/master' into s/array-fixes

Author: shashi

Project.toml

@@ -1,7 +1,7 @@
 name = "ModelingToolkit"
 uuid = "961ee093-0014-501f-94e3-6117800e7a78"
 authors = ["Chris Rackauckas <[email protected]>"]
-version = "5.18.2"
+version = "5.19.1"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"

docs/Project.toml

@@ -3,4 +3,4 @@ ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
 Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
 
 [compat]
-Documenter = "0.24.2"
+Documenter = "0.27"

src/systems/jumps/jumpsystem.jl

@@ -61,7 +61,8 @@ function JumpSystem(eqs, iv, states, ps;
                     defaults=_merge(Dict(default_u0), Dict(default_p)),
                     name = gensym(:JumpSystem),
                     connection_type=nothing,
-                    )
+                    kwargs...)
+                    
     sysnames = nameof.(systems)
     if length(unique(sysnames)) != length(sysnames)
         throw(ArgumentError("System names must be unique."))

test/reactionsystem.jl

@@ -197,6 +197,10 @@ dprob = DiscreteProblem(js, [S => 1, I => 1], (0.0,10.0))
 jprob = JumpProblem(js, dprob, Direct())
 sol = solve(jprob, SSAStepper())
 
+# test for https://github.com/SciML/ModelingToolkit.jl/issues/1042
+jprob = JumpProblem(rs, dprob, Direct(), save_positions=(false,false))
+
+
 @parameters k1 k2
 @variables R
 rxs = [Reaction(k1*S, [S,I], [I], [2,3], [2]),