-
-
Notifications
You must be signed in to change notification settings - Fork 234
Open
Description
-
Here, I think it should be
rober!instead ofrober. - In the global structural identifiability tutorial:
a. The docs say that "We can see that all states (except$x_7$ ) and all parameters are locally identifiable", despite the results don't show any states.
b. Why does it say that "We can see that only parameters a, g are unidentifiable", when the result suggest onlygis unidentifiable.
c. In the case of inputsu1andu2It is unclear whether these inputs are known perturbations (to improve identifiability) or are unknown and shall be estimated (reduces identifiability). In case of the former, the example should test ifgis now identifiable. In the case of the latter, it would still be interesting to know why we are not checking for all parameters.
d. AFAIK structural identifiability methods scale poorly to large models. Maybe it would be good to add a sentence on scalability. - The example for DAE Index Reduction uses
structural_simplify(dae_index_lowering(traced_sys)), despite another place states that this is superfluous, as structural_simplify calls it internally. Maybe worth clarifying.
Metadata
Metadata
Assignees
Labels
No labels