Missing metadata getters

[TorkelE]

It seems that getters for these metadata are missing: misc, input. Possibly this holds for a few others.

[vyudu]

@TorkelE Is this metadata for XSystems? Or something else? not seeing any XSystems that have input and misc as fields

[TorkelE]

Sorry, symbolic metadata: https://docs.sciml.ai/ModelingToolkit/stable/basics/Variable_metadata/

Typically, a metadata md has two corresponding functions hasmd and getmd. But these metadata lacks them. basically you have to implement getmisc and getinput` so that

using ModelingToolkit
@parameters p [misc=["Random", :metadata]]
ModelingToolkit.getmisc(X)

works.

Check how similar functions are working. It can be worthwhile to see if you can find a list somewhere (and if there is not an exhaustive one, creating it) and checking that each one have both the hasX and getX functions.

As an example, it is using symbolic metadata that we e.g. have implemented the metadata tag telling us that a parameter is a conservation law parameter.

[vyudu]

Added misc, though I think input is already there as isinput

[TorkelE]

But is getinput?

…

On Thursday, 16 January 2025, Vincent Du ***@***.***> wrote: Added misc, though I think input is already there as isinput — Reply to this email directly, view it on GitHub <#2643 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEKCY3TCR7SXDPT6V7LXTTD2LAFRRAVCNFSM6AAAAABU3USHSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWG44DCOJVGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vyudu]

The input field is just a Bool that says whether the variable is an input, I thought?

[TorkelE]

Yes (Stored as a symbolic variable metadata)

…

On Thursday, 16 January 2025, Vincent Du ***@***.***> wrote: The input field is just a Bool that says whether the variable is an input, I thought? — Reply to this email directly, view it on GitHub <#2643 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEKCY3RGY2QVNMPCYZOHECL2LATH7AVCNFSM6AAAAABU3USHSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWHE4DKNJTGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vyudu]

It seems like all of the boolean metadata variables just have isX as the getter (like input, output, irreducible). Is there a reason to write a separate getX?

[TorkelE]

To be honest, you are probably right. I was thinking of some system where it loops through metadata, but doesn't really make sense.