feat: throw error when differentiating registered function with no derivative in structural_simplify
#3419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That should error. For the test, let's just define the derivatives. |
AayushSabharwal
force-pushed
the
as/throw-no-derivative
branch
from
cf940a8 to
05d304b
Compare
AayushSabharwal
force-pushed
the
as/throw-no-derivative
branch
from
05d304b to
4defc22
Compare
AayushSabharwal
force-pushed
the
as/throw-no-derivative
branch
from
4defc22 to
8c43ac5
Compare
|
Rebased again to run Catalyst downstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires JuliaSymbolics/Symbolics.jl#1448
Close #3370
This mostly works. The problem is this test, specifically these equations.
yis defined asget_value(interpolator, t)and subsequently there are equationsD(y) ~ dyandD(D(y)) ~ ddy. Since the derivative ofget_valueisn't defined, with the changes in this PRstructural_simplifywould error. However, those equations become observed and have no role in solving the system, so technically they can be ignored and the system solved. The question is whether we want to error or retain the somewhat broken behavior.