Skip to content

Conversation

@vyudu
Copy link
Member

@vyudu vyudu commented Apr 25, 2025

A couple of needed optimal control utilities

@vyudu vyudu marked this pull request as draft April 28, 2025 13:36
@vyudu vyudu marked this pull request as ready for review April 28, 2025 20:50
@vyudu
Copy link
Member Author

vyudu commented Apr 29, 2025

@ChrisRackauckas I think this is ready - I'd like to merge this soon so I can use it for some of the component-based optimal control tests

@ChrisRackauckas
Copy link
Member

I think it looks good now. But I think At might be a name that is too easy to hit in user code, so it could cause weird issues with common codes. At could easily be A transpose in a script, now hitting the export. Could we just change to a different name and let people EvalAt as At or something?

@ChrisRackauckas
Copy link
Member

@vyudu
Copy link
Member Author

vyudu commented May 3, 2025

I think the new BoundaryValueDiffEq release broke some of these tests but I haven't dug into yet, was planning on doing that soon (these failures show up on other PRs too too)

@vyudu
Copy link
Member Author

vyudu commented May 3, 2025

But they should'nt be related to this one

@ChrisRackauckas
Copy link
Member

confirm the failure is on master?

ChrisRackauckas added a commit that referenced this pull request May 3, 2025
@ChrisRackauckas ChrisRackauckas mentioned this pull request May 3, 2025
@ChrisRackauckas
Copy link
Member

#3596

@ChrisRackauckas
Copy link
Member

Matches #3596

@ChrisRackauckas ChrisRackauckas merged commit 8c6b5ad into SciML:master May 3, 2025
32 of 45 checks passed
@vyudu vyudu deleted the opt_ctrl_utils branch May 3, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants