add RealtimeClock #2414
Open
add RealtimeClock #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase? |
|
The PR is over a year old now so it's incredibly stale, and some of the features it relies upon are no longer present in MTK. It would probably make more sense to wait until the new clocking support has gotten a bit further and then cut out the parts of this PR that are still relevant into a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
RealtimeClock <: AbstractClockwhich behaves identically to the standardClock, but forces the simulation to progress in (no faster than) real time, i.e., a simulation withtspan = (0, 10)will take 10 seconds of wall-clock time as long as the computations are fast enough to meet the chosen sample rate.The PR also refactors the generation of the callback associated with the clock so that it is easier to add new clock implementations