Skip to content

Conversation

@AayushSabharwal
Copy link
Member

The old implementation broke Catalyst, but it wasn't detected due to differing BifurcationKit compats preventing tests from running.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Extension test failing? Seems unrelated though.

@ChrisRackauckas ChrisRackauckas merged commit 5031a9d into SciML:master Oct 28, 2024
35 of 39 checks passed
@AayushSabharwal
Copy link
Member Author

Huh, weird, it only fails on lts.

@AayushSabharwal AayushSabharwal deleted the as/getproperty branch October 28, 2024 07:14
@ChrisRackauckas
Copy link
Member

Must be an alternative solution or something, just choosing the wrong root?

@AayushSabharwal
Copy link
Member Author

Nope, it's a bug. x = 2 is an invalid root because it occurs in the denominator, but I forgot to add an abs in the check so it accepts 2 - 2e-8 but rejects 2 + 2e-8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants