Skip to content

Copy MTKParameters fields only if not empty #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Copy MTKParameters fields only if not empty #3579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18855ab
chore: copy MTKparameter fields only if not empty
DhairyaLGandhi Apr 23, 2025
e8b1d8e
test: add test to check field equality
DhairyaLGandhi Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/systems/parameter_buffer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ function Base.copy(p::MTKParameters)
initials = copy(p.initials)
discrete = Tuple(eltype(buf) <: Real ? copy(buf) : copy.(buf) for buf in p.discrete)
constant = Tuple(eltype(buf) <: Real ? copy(buf) : copy.(buf) for buf in p.constant)
nonnumeric = copy.(p.nonnumeric)
caches = copy.(p.caches)
nonnumeric = isempty(p.nonnumeric) ? p.nonnumeric : copy.(p.nonnumeric)
caches = isempty(p.caches) ? p.caches : copy.(p.caches)
return MTKParameters(
tunable,
initials,
Expand Down
Loading