-
-
Notifications
You must be signed in to change notification settings - Fork 232
Allow system level metadata information #3892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
InterfaceI is failing |
It's seemingly related to units, is that something this PR could break? I did rebase this branch recently as well |
The error is specifically in the test added in this PR, and there is no unit failure on master or the recently opened #3912 so it is likely that something here is wrong. |
Hmm, unable to reproduce locally. I get struct Author end
struct MyVersion end
struct License end
struct Category end
struct Tags end
struct MyBool end
struct NewInt end
@mtkmodel TestMetadataModel begin
@metadata begin
Author = "Test Author"
MyVersion = "1.0.0"
License = "MIT"
Category => "example"
Tags = ["test", "demo", "metadata"]
MyBool => false
NewInt => 1
end
@parameters begin
k = 1.0, [description = "Gain parameter"]
end
@variables begin
x(t), [description = "State variable"]
y(t), [description = "Output variable"]
end
@equations begin
D(x) ~ -k * x
y ~ x
end
end julia> @named test_model = TestMetadataModel()
Model test_model:
Equations (2):
2 standard: see equations(test_model)
Unknowns (2): see unknowns(test_model)
x(t): State variable
y(t): Output variable
Parameters (1): see parameters(test_model)
k [defaults to 1.0]: Gain parameter |
Does it reproduce if you run the entire testset locally? Or just that file? |
Let me try running the whole test suite locally. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Ref #3734
Add any other context about the problem here.
Are there cases where there are expression evaluations anywhere for the model parsing? Currently everything is delayed, but that means local variables are not referred to properly, and
esc
will simply convert the escaped expression, whereas we need it as parse/ expansion time.