@@ -358,7 +358,7 @@ Valve with `area` input and discharge coefficient `Cd` defined by https://en.wik
358358end
359359
360360@component function VolumeBase (; area, dead_volume = 0 , Χ1 = 1 , Χ2 = 1 ,
361- name) # x_int = 0,
361+ name)
362362 pars = @parameters begin
363363 area = area
364364 dead_volume = dead_volume
373373 dx (t), [guess = 0 ]
374374 rho (t), [guess = liquid_density (port)]
375375 drho (t), [guess = 0 ]
376- vol (t) # = dead_volume + area * x_int
376+ vol (t)
377377 end
378378
379379 # let
@@ -551,7 +551,6 @@ dm ────► │ │ area
551551- `flange`: mechanical translational port
552552"""
553553@component function DynamicVolume (N, add_inertia = true , reversible = false ;
554- # p_int,
555554 area,
556555 x_int = 0 ,
557556 x_max,
@@ -575,16 +574,13 @@ dm ────► │ │ area
575574
576575 # TODO : How to set an assert effective_length >= length ??
577576 pars = @parameters begin
578- # p_int = p_int
579577 area = area
580578
581579 x_int = x_int
582580 x_max = x_max
583581 x_min = x_min
584582 x_damp = x_damp
585583
586- # direction = direction
587-
588584 perimeter = perimeter
589585 shape_factor = shape_factor
590586 head_factor = head_factor
@@ -619,7 +615,6 @@ dm ────► │ │ area
619615 # TODO : How to handle x_int?
620616 # TODO : Handle direction
621617 @named moving_volume = VolumeBase (;
622- # x_int = 0,
623618 area,
624619 dead_volume = N == 0 ? area * x_int : 0 ,
625620 Χ1 = N == 0 ? 1 : 0 ,
@@ -651,7 +646,6 @@ dm ────► │ │ area
651646 zero (Δx)))
652647
653648 comp = VolumeBase (; name = Symbol (" v$i " ),
654- # x_int = 0,
655649 area = ParentScope (area),
656650 dead_volume = ParentScope (area) * length, Χ1 = 1 , Χ2 = 0 )
657651
0 commit comments