fix: change certain defaults to guesses in Blocks

Author: avinashresearch1

src/Blocks/continuous.jl

@@ -20,7 +20,7 @@ Initial value of integrator state ``x`` can be set with `x`
 @mtkmodel Integrator begin
     @extend u, y = siso = SISO()
     @variables begin
-        x(t) = 0.0, [description = "State of Integrator"]
+        x(t), [guess = 0.0, description = "State of Integrator"]
     end
     @parameters begin
         k = 1, [description = "Gain"]
@@ -65,7 +65,7 @@ Initial value of the state ``x`` can be set with `x`.
 @mtkmodel Derivative begin
     @extend u, y = siso = SISO()
     @variables begin
-        x(t) = 0.0, [description = "Derivative-filter state"]
+        x(t), [guess = 0.0, description = "Derivative-filter state"]
     end
     @parameters begin
         T = T, [description = "Time constant"]
@@ -122,7 +122,7 @@ See also [`SecondOrder`](@ref)
         lowpass = true
     end
     @variables begin
-        x(t) = 0.0, [description = "State of FirstOrder filter"]
+        x(t), [guess = 0.0, description = "State of FirstOrder filter"]
     end
     @parameters begin
         T = T, [description = "Time constant"]
@@ -545,7 +545,7 @@ linearized around the operating point `x₀, u₀`, we have `y0, u0 = h(x₀, u
     end
     @named input = RealInput(nin = nu)
     @named output = RealOutput(nout = ny)
-    @variables x(t)[1:nx]=x [
+    @variables x(t)[1:nx]=x [ # FIXME: should it be guess = x, not default? 
         description = "State variables of StateSpace system $name"
     ]
     # pars = @parameters A=A B=B C=C D=D # This is buggy
@@ -618,7 +618,7 @@ See also [`StateSpace`](@ref) which handles MIMO systems, as well as [ControlSys
     @parameters a_end = ifelse(a[end] > 100 * symbolic_eps(sqrt(a' * a)), a[end], 1.0)
 
     pars = [collect(b); a; collect(bb); d; a_end]
-    @variables begin
+    @variables begin # FIXME: should it be guesses, not default? 
         x(t)[1:nx] = zeros(nx),
         [description = "State of transfer function on controller canonical form"]
         x_scaled(t)[1:nx] = collect(x) * a_end, [description = "Scaled vector x"]

src/Blocks/utils.jl

@@ -1,11 +1,13 @@
 @connector function RealInput(; name, nin = 1, u_start = nin > 1 ? zeros(nin) : 0.0)
     if nin == 1
-        @variables u(t)=u_start [
+        @variables u(t) [
+            guess = u_start,
             input = true,
             description = "Inner variable in RealInput $name"
         ]
     else
-        @variables u(t)[1:nin]=u_start [
+        @variables u(t)[1:nin] [
+            guess = u_start,
             input = true,
             description = "Inner variable in RealInput $name"
         ]
@@ -28,12 +30,14 @@ Connector with one input signal of type Real.
 
 @connector function RealOutput(; name, nout = 1, u_start = nout > 1 ? zeros(nout) : 0.0)
     if nout == 1
-        @variables u(t)=u_start [
+        @variables u(t) [
+            guess = u_start,
             output = true,
             description = "Inner variable in RealOutput $name"
         ]
     else
-        @variables u(t)[1:nout]=u_start [
+        @variables u(t)[1:nout] [
+            guess = u_start,
             output = true,
             description = "Inner variable in RealOutput $name"
         ]
@@ -70,8 +74,8 @@ Single input single output (SISO) continuous system block.
         y_start = 0.0
     end
     @variables begin
-        u(t) = u_start, [description = "Input of SISO system"]
-        y(t) = y_start, [description = "Output of SISO system"]
+        u(t), [guess = u_start, description = "Input of SISO system"]
+        y(t), [guess = y_start, description = "Output of SISO system"]
     end
     @components begin
         input = RealInput(u_start = u_start)
@@ -99,8 +103,10 @@ Base class for a multiple input multiple output (MIMO) continuous system block.
         y_start = zeros(nout))
     @named input = RealInput(nin = nin, u_start = u_start)
     @named output = RealOutput(nout = nout, u_start = y_start)
-    @variables(u(t)[1:nin]=u_start, [description = "Input of MIMO system $name"],
-        y(t)[1:nout]=y_start, [description = "Output of MIMO system $name"],)
+    @variables begin
+        u(t)[1:nin], [guess = u_start, description = "Input of MIMO system $name"]
+        y(t)[1:nout], [guess = y_start, description = "Output of MIMO system $name"]
+    end
     eqs = [
         [u[i] ~ input.u[i] for i in 1:nin]...,
         [y[i] ~ output.u[i] for i in 1:nout]...