Skip to content

Commit 83a1f30

Browse files
author
Brad Carman
committed
fixed Actuator test
1 parent 640d801 commit 83a1f30

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Hydraulic/IsothermalCompressible/components.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ See also [`FixedVolume`](@ref), [`DynamicVolume`](@ref)
508508
end
509509

510510
"""
511-
DynamicVolume(; p_int, area, x_int = 0, x_max, x_min = 0, x_damp = x_min, direction = +1, perimeter = 2 * sqrt(area * pi), shape_factor = 64, head_factor = 1, Cd = 1e2, Cd_reverse = Cd, name)
511+
DynamicVolume(reversible = false; p_int, area, x_int = 0, x_max, x_min = 0, x_damp = x_min, direction = +1, perimeter = 2 * sqrt(area * pi), shape_factor = 64, head_factor = 1, Cd = 1e2, Cd_reverse = Cd, name)
512512
513513
Volume with moving wall with `flange` connector for converting hydraulic energy to 1D mechanical. The `direction` argument aligns the mechanical port with the hydraulic port, useful when connecting two dynamic volumes together in oppsing directions to create an actuator.
514514

test/Hydraulic/isothermal_compressible.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ end
219219

220220
systems = @named begin
221221
src = IC.FixedPressure(; p = p_s)
222-
valve = IC.SpoolValve2Way(; g, m = m_f, d, Cd, x_int = 0, dx_int = 0)
222+
valve = IC.SpoolValve2Way(; g, m = m_f, d, Cd, x_int = 0)
223223
piston = IC.Actuator(;
224224
length_a_int = l_1,
225225
length_b_int = l_2,
@@ -345,7 +345,7 @@ end
345345
prob2 = ODEProblem(sys, [], (0, 0.05), [sys.let_gas => 0])
346346

347347
# @time sol1 = solve(prob1, Rodas5P(); abstol=1e-9, reltol=1e-9) #BUG: Using BigFloat gives... ERROR: MethodError: no method matching getindex(::Missing, ::Int64)
348-
@time sol1 = solve(prob1, Rodas5P(); adaptive = false, dt = 1e-6) #TODO: fix BigFloat to implment abstol=1e-9, reltol=1e-9
348+
@time sol1 = solve(prob1, Rodas5P(); adaptive = false, dt = 1e-6) #TODO: fix BigFloat to implement abstol=1e-9, reltol=1e-9
349349
@time sol2 = solve(prob2, Rodas5P())
350350

351351
# case 1: no negative pressure will only have gravity pulling mass back down

0 commit comments

Comments
 (0)