Skip to content

Commit 3b52a5a

Browse files
committed
More tests pass
1 parent 8666e05 commit 3b52a5a

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/trustRegion.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ end
236236

237237
function SciMLBase.__init(prob::NonlinearProblem{uType, iip}, alg_::TrustRegion, args...;
238238
alias_u0 = false, maxiters = 1000, abstol = nothing, reltol = nothing,
239-
termination_condition = nothing, internalnorm = Base.Fix2(norm, 2),
239+
termination_condition = nothing, internalnorm = DEFAULT_NORM,
240240
linsolve_kwargs = (;), kwargs...) where {uType, iip}
241241
alg = get_concrete_algorithm(alg_, prob)
242242
@unpack f, u0, p = prob

test/23_test_problems.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ end
7575
broken_tests = Dict(alg => Int[] for alg in alg_ops)
7676
broken_tests[alg_ops[1]] = [3, 6, 11, 17, 21]
7777
broken_tests[alg_ops[2]] = [3, 6, 11, 17, 21]
78-
broken_tests[alg_ops[3]] = [6, 11, 17, 21]
78+
broken_tests[alg_ops[3]] = [6, 11, 21]
7979

8080
test_on_library(problems, dicts, alg_ops, broken_tests)
8181
end
@@ -89,8 +89,6 @@ end
8989
test_on_library(problems, dicts, alg_ops, broken_tests)
9090
end
9191

92-
# Broyden and Klement Tests are quite flaky and failure seems to be platform dependent
93-
# needs additional investigation before we can enable them
9492
@testset "GeneralBroyden 23 Test Problems" begin
9593
alg_ops = (GeneralBroyden(; max_resets = 10),)
9694

0 commit comments

Comments
 (0)