Revert "Add NonlinearKeywordArgError to accept lb and ub in NonlinearSolveBase"

This reverts commit 8cb8c42.

Author: ChrisRackauckas

lib/NonlinearSolveBase/src/NonlinearSolveBase.jl

@@ -42,35 +42,6 @@ using Printf: @printf
 const DI = DifferentiationInterface
 const SII = SymbolicIndexingInterface
 
-# Custom keyword argument handler that extends the standard SciMLBase keywords
-# to include bounds (lb, ub) for NonlinearLeastSquaresProblem
-struct NonlinearKeywordArgError end
-
-function SciMLBase.checkkwargs(::Type{NonlinearKeywordArgError}; kwargs...)
-    keywords = keys(kwargs)
-    allowed_keywords = (:dense, :saveat, :save_idxs, :save_discretes, :tstops, :tspan,
-                       :d_discontinuities, :save_everystep, :save_on, :save_start, :save_end,
-                       :initialize_save, :adaptive, :abstol, :reltol, :dt, :dtmax, :dtmin,
-                       :force_dtmin, :internalnorm, :controller, :gamma, :beta1, :beta2,
-                       :qmax, :qmin, :qsteady_min, :qsteady_max, :qoldinit, :failfactor,
-                       :calck, :alias_u0, :maxiters, :maxtime, :callback, :isoutofdomain,
-                       :unstable_check, :verbose, :merge_callbacks, :progress, :progress_steps,
-                       :progress_name, :progress_message, :progress_id, :timeseries_errors,
-                       :dense_errors, :weak_timeseries_errors, :weak_dense_errors, :wrap,
-                       :calculate_error, :initializealg, :alg, :save_noise, :delta, :seed,
-                       :alg_hints, :kwargshandle, :trajectories, :batch_size, :sensealg,
-                       :advance_to_tstop, :stop_at_next_tstop, :u0, :p, :default_set,
-                       :second_time, :prob_choice, :alias_jump, :alias_noise, :batch,
-                       :nlsolve_kwargs, :odesolve_kwargs, :linsolve_kwargs, :ensemblealg,
-                       :show_trace, :trace_level, :store_trace, :termination_condition,
-                       :alias, :fit_parameters, :lb, :ub)  # Added lb and ub
-    for kw in keywords
-        if kw ∉ allowed_keywords
-            throw(SciMLBase.KeywordArgumentError(kw))
-        end
-    end
-end
-
 include("public.jl")
 include("utils.jl")
 include("verbosity.jl")

lib/NonlinearSolveBase/src/solve.jl

@@ -171,42 +171,6 @@ function solve_call(prob::SteadyStateProblem,
         kwargs...)
 end
 
-function solve_call(prob::NonlinearLeastSquaresProblem, args...;
-        merge_callbacks = true, kwargshandle = nothing, kwargs...)
-    # Use NonlinearKeywordArgError which accepts lb and ub
-    kwargshandle = kwargshandle === nothing ? NonlinearKeywordArgError : kwargshandle
-    kwargshandle = has_kwargs(prob) && haskey(prob.kwargs, :kwargshandle) ?
-                   prob.kwargs[:kwargshandle] : kwargshandle
-
-    if has_kwargs(prob)
-        kwargs = isempty(prob.kwargs) ? kwargs : merge(values(prob.kwargs), kwargs)
-    end
-
-    checkkwargs(kwargshandle; kwargs...)
-    if isdefined(prob, :u0)
-        if prob.u0 isa Array
-            if !isconcretetype(RecursiveArrayTools.recursive_unitless_eltype(prob.u0))
-                throw(NonConcreteEltypeError(RecursiveArrayTools.recursive_unitless_eltype(prob.u0)))
-            end
-
-            if !(eltype(prob.u0) <: Number) && !(eltype(prob.u0) <: Enum)
-                throw(NonNumberEltypeError(eltype(prob.u0)))
-            end
-        end
-
-        if prob.u0 === nothing
-            return build_null_solution(prob, args...; kwargs...)
-        end
-    end
-
-    if hasfield(typeof(prob), :f) && hasfield(typeof(prob.f), :f) &&
-       prob.f.f isa EvalFunc
-        Base.invokelatest(__solve, prob, args...; kwargs...)
-    else
-        __solve(prob, args...; kwargs...)
-    end
-end
-
 function init(
         prob::AbstractNonlinearProblem, args...; sensealg = nothing,
         u0 = nothing, p = nothing, verbose = NonlinearVerbosity(), kwargs...)
@@ -294,25 +258,6 @@ function init_call(_prob, args...; merge_callbacks=true, kwargshandle=nothing,
     end
 end
 
-function init_call(prob::NonlinearLeastSquaresProblem, args...;
-        merge_callbacks = true, kwargshandle = nothing, kwargs...)
-    # Use NonlinearKeywordArgError which accepts lb and ub
-    kwargshandle = kwargshandle === nothing ? NonlinearKeywordArgError : kwargshandle
-    kwargshandle = has_kwargs(prob) && haskey(prob.kwargs, :kwargshandle) ?
-                   prob.kwargs[:kwargshandle] : kwargshandle
-    if has_kwargs(prob)
-        kwargs = isempty(prob.kwargs) ? kwargs : merge(values(prob.kwargs), kwargs)
-    end
-
-    checkkwargs(kwargshandle; kwargs...)
-    if hasfield(typeof(prob), :f) && hasfield(typeof(prob.f), :f) &&
-           prob.f.f isa EvalFunc
-        Base.invokelatest(__init, prob, args...; kwargs...)
-    else
-        __init(prob, args...; kwargs...)
-    end
-end
-
 function SciMLBase.__solve(
         prob::AbstractNonlinearProblem, alg::AbstractNonlinearSolveAlgorithm, args...; kwargs...)
     cache = SciMLBase.__init(prob, alg, args...; kwargs...)