Minor fixes after rebasing

Author: utkarsh530

src/dfsane.jl

@@ -314,7 +314,8 @@ function SciMLBase.solve!(cache::DFSaneCache)
 end
 
 function SciMLBase.reinit!(cache::DFSaneCache{iip}, u0 = cache.uₙ; p = cache.p,
-    abstol = cache.abstol, termination_condition = cache.termination_condition,
+    abstol = cache.abstol, reltol = cache.reltol,
+    termination_condition = cache.termination_condition,
     maxiters = cache.maxiters) where {iip}
     cache.p = p
     if iip

src/gaussnewton.jl

@@ -131,7 +131,7 @@ function perform_step!(cache::GaussNewtonCache{true})
     jacobian!!(J, cache)
 
     termination_condition = cache.termination_condition(tc_storage)
-  
+
     if JᵀJ !== nothing
         __matmul!(JᵀJ, J', J)
         __matmul!(Jᵀf, J', fu1)

src/levenberg.jl

@@ -219,7 +219,7 @@ function SciMLBase.__init(prob::Union{NonlinearProblem{uType, iip},
 
     storage = mode ∈ DiffEqBase.SAFE_TERMINATION_MODES ? NLSolveSafeTerminationResult() :
               nothing
-  
+
     if _unwrap_val(linsolve_with_JᵀJ)
         mat_tmp = zero(JᵀJ)
         rhs_tmp = nothing
@@ -232,19 +232,22 @@ function SciMLBase.__init(prob::Union{NonlinearProblem{uType, iip},
         linsolve = __setup_linsolve(mat_tmp, rhs_tmp, u, p, alg)
     end
 
-    return LevenbergMarquardtCache{iip, !_unwrap_val(linsolve_with_JᵀJ)}(f, alg, u, fu1,
+    return LevenbergMarquardtCache{iip, !_unwrap_val(linsolve_with_JᵀJ)}(f, alg, u, copy(u),
+        fu1,
         fu2, du, p, uf, linsolve, J,
-        jac_cache, false, maxiters, internalnorm, ReturnCode.Default, abstol, reltol, prob, DᵀD,
+        jac_cache, false, maxiters, internalnorm, ReturnCode.Default, abstol, reltol, prob,
+        DᵀD,
         JᵀJ, λ, λ_factor, damping_increase_factor, damping_decrease_factor, h, α_geodesic,
         b_uphill, min_damping_D, v, a, tmp_vec, v_old, loss, δ, loss, make_new_J, fu_tmp,
-        zero(u), zero(fu1), mat_tmp, rhs_tmp, J², NLStats(1, 0, 0, 0, 0), termination_condition, storage)
+        zero(u), zero(fu1), mat_tmp, rhs_tmp, J², NLStats(1, 0, 0, 0, 0),
+        termination_condition, storage)
 end
 
 function perform_step!(cache::LevenbergMarquardtCache{true, fastls}) where {fastls}
     @unpack fu1, f, make_new_J, tc_storage = cache
 
     termination_condition = cache.termination_condition(tc_storage)
-  
+
     if iszero(fu1)
         cache.force_stop = true
         return nothing

src/raphson.jl

@@ -102,7 +102,8 @@ function SciMLBase.__init(prob::NonlinearProblem{uType, iip}, alg_::NewtonRaphso
 
     return NewtonRaphsonCache{iip}(f, alg, u, copy(u), fu1, fu2, du, p, uf, linsolve, J,
         jac_cache, false, maxiters, internalnorm, ReturnCode.Default, abstol, reltol, prob,
-        NLStats(1, 0, 0, 0, 0), init_linesearch_cache(alg.linesearch, f, u, p, fu1, Val(iip)),
+        NLStats(1, 0, 0, 0, 0),
+        init_linesearch_cache(alg.linesearch, f, u, p, fu1, Val(iip)),
         termination_condition, storage)
 end
 

src/trustRegion.jl

@@ -724,7 +724,8 @@ end
 get_fu(cache::TrustRegionCache) = cache.fu
 
 function SciMLBase.reinit!(cache::TrustRegionCache{iip}, u0 = cache.u; p = cache.p,
-    abstol = cache.abstol, termination_condition = cache.termination_condition,
+    abstol = cache.abstol, reltol = cache.reltol,
+    termination_condition = cache.termination_condition,
     maxiters = cache.maxiters) where {iip}
     cache.p = p
     if iip

src/utils.jl

@@ -324,4 +324,4 @@ end
 
 _needs_square_A(_, ::Number) = true
 _needs_square_A(_, ::StaticArray) = true
-_needs_square_A(alg, _) = LinearSolve.needs_square_A(alg.linsolve)
+_needs_square_A(alg, _) = LinearSolve.needs_square_A(alg.linsolve)

test/23_test_problems.jl

@@ -75,7 +75,7 @@ end
     alg_ops = (DFSane(),)
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
-    broken_tests[alg_ops[1]] = [1, 2, 3, 5, 6, 8, 12, 13, 14, 21]
+    broken_tests[alg_ops[1]] = [1, 2, 3, 5, 6, 21]
 
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end