don't reset aliasing on reinit!

oscardssmith · ChrisRackauckas · commit 8bfe4f105a1c · 2025-08-06T23:38:55.000-04:00
diff --git a/lib/NonlinearSolveFirstOrder/src/solve.jl b/lib/NonlinearSolveFirstOrder/src/solve.jl
@@ -93,7 +93,7 @@ end
 
 function InternalAPI.reinit_self!(
         cache::GeneralizedFirstOrderAlgorithmCache, args...; p = cache.p, u0 = cache.u,
-        alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...
+        alias_u0::Bool = cache.alias_u0, maxiters = cache.maxiters, maxtime = cache.maxtime, kwargs...
 )
     Utils.reinit_common!(cache, u0, p, alias_u0)
 
diff --git a/lib/NonlinearSolveQuasiNewton/src/solve.jl b/lib/NonlinearSolveQuasiNewton/src/solve.jl
@@ -107,7 +107,7 @@ end
 
 function InternalAPI.reinit_self!(
         cache::QuasiNewtonCache, args...; p = cache.p, u0 = cache.u,
-        alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...
+        alias_u0::Bool = cache.alias_u0, maxiters = cache.maxiters, maxtime = cache.maxtime, kwargs...
 )
     Utils.reinit_common!(cache, u0, p, alias_u0)
 
diff --git a/lib/NonlinearSolveSpectralMethods/src/solve.jl b/lib/NonlinearSolveSpectralMethods/src/solve.jl
@@ -74,7 +74,7 @@ end
 
 function InternalAPI.reinit_self!(
         cache::GeneralizedDFSaneCache, args...; p = cache.p, u0 = cache.u,
-        alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...
+        alias_u0::Bool = cache.alias_u0, maxiters = cache.maxiters, maxtime = cache.maxtime, kwargs...
 )
     Utils.reinit_common!(cache, u0, p, alias_u0)
     T = eltype(u0)

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ end`
`93`	`93`
`94`	`94`	`function InternalAPI.reinit_self!(`
`95`	`95`	`cache::GeneralizedFirstOrderAlgorithmCache, args...; p = cache.p, u0 = cache.u,`
`96`		`- alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...`
	`96`	`+ alias_u0::Bool = cache.alias_u0, maxiters = cache.maxiters, maxtime = cache.maxtime, kwargs...`
`97`	`97`	`)`
`98`	`98`	`Utils.reinit_common!(cache, u0, p, alias_u0)`
`99`	`99`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ end`
`107`	`107`
`108`	`108`	`function InternalAPI.reinit_self!(`
`109`	`109`	`cache::QuasiNewtonCache, args...; p = cache.p, u0 = cache.u,`
`110`		`- alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...`
	`110`	`+ alias_u0::Bool = cache.alias_u0, maxiters = cache.maxiters, maxtime = cache.maxtime, kwargs...`
`111`	`111`	`)`
`112`	`112`	`Utils.reinit_common!(cache, u0, p, alias_u0)`
`113`	`113`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ end`
`74`	`74`
`75`	`75`	`function InternalAPI.reinit_self!(`
`76`	`76`	`cache::GeneralizedDFSaneCache, args...; p = cache.p, u0 = cache.u,`
`77`		`- alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...`
	`77`	`+ alias_u0::Bool = cache.alias_u0, maxiters = cache.maxiters, maxtime = cache.maxtime, kwargs...`
`78`	`78`	`)`
`79`	`79`	`Utils.reinit_common!(cache, u0, p, alias_u0)`
`80`	`80`	`T = eltype(u0)`