refactor: do not use similar(p)

Author: vyudu

lib/SimpleImplicitDiscreteSolve/Project.toml

@@ -9,6 +9,7 @@ OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"
 Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
 SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
 SimpleNonlinearSolve = "727e6d20-b764-4bd8-a329-72de5adea6c7"
+SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
 UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"
 
 [compat]
@@ -18,6 +19,7 @@ OrdinaryDiffEqSDIRK = "1.2.0"
 Reexport = "1.2.2"
 SciMLBase = "2.74.1"
 SimpleNonlinearSolve = "2.1.0"
+SymbolicIndexingInterface = "0.3.38"
 UnPack = "1.0.2"
 
 [extras]

lib/SimpleImplicitDiscreteSolve/src/SimpleImplicitDiscreteSolve.jl

@@ -3,6 +3,7 @@ module SimpleImplicitDiscreteSolve
 using SciMLBase
 using SimpleNonlinearSolve
 using UnPack
+using SymbolicIndexingInterface: parameter_values
 import OrdinaryDiffEqCore: OrdinaryDiffEqAlgorithm, alg_cache, OrdinaryDiffEqMutableCache, OrdinaryDiffEqConstantCache, get_fsalfirstlast, isfsal, initialize!, perform_step!, isdiscretecache, isdiscretealg, alg_order, beta2_default, beta1_default, dt_required
 
 using Reexport

lib/SimpleImplicitDiscreteSolve/src/cache.jl

@@ -1,6 +1,6 @@
 mutable struct ImplicitDiscreteState{uType, pType, tType}
     u::Vector{uType}
-    p::Union{Nothing, Vector{pType}}
+    p::pType
     t_next::tType
 end
 
@@ -16,7 +16,7 @@ function alg_cache(alg::SimpleIDSolve, u, rate_prototype, ::Type{uEltypeNoUnits}
         dt, reltol, p, calck,
         ::Val{true}) where {uEltypeNoUnits, uBottomEltypeNoUnits, tTypeNoUnits}
 
-    state = ImplicitDiscreteState(similar(u), similar(p), t)
+    state = ImplicitDiscreteState(similar(u), p, t)
     SimpleIDSolveCache(u, uprev, state, nothing)
 end
 
@@ -31,7 +31,7 @@ function alg_cache(alg::SimpleIDSolve, u, rate_prototype, ::Type{uEltypeNoUnits}
         dt, reltol, p, calck,
         ::Val{false}) where {uEltypeNoUnits, uBottomEltypeNoUnits, tTypeNoUnits}
 
-    state = ImplicitDiscreteState(similar(u), similar(p), t)
+    state = ImplicitDiscreteState(similar(u), p, t)
     SimpleIDSolveCache(u, uprev, state, nothing)
 end
 

lib/SimpleImplicitDiscreteSolve/src/solve.jl

@@ -13,6 +13,7 @@ end
 
 function initialize!(integrator, cache::SimpleIDSolveCache)
     cache.state.u .= integrator.u
+    @show integrator.p
     cache.state.p .= integrator.p
     cache.state.t_next = integrator.t
     f = integrator.f

src/NonlinearSolve.jl

@@ -113,7 +113,8 @@ end
 # Rexexports
 @reexport using SciMLBase, NonlinearSolveBase, LineSearch, ADTypes
 @reexport using NonlinearSolveFirstOrder, NonlinearSolveSpectralMethods,
-                NonlinearSolveQuasiNewton, SimpleNonlinearSolve, BracketingNonlinearSolve
+                NonlinearSolveQuasiNewton, SimpleNonlinearSolve, BracketingNonlinearSolve,
+                SimpleImplicitDiscreteSolve
 @reexport using LinearSolve
 
 # Poly Algorithms