Reenable some of the 23 test problems tests

Author: avik-pal

src/lbroyden.jl

@@ -25,7 +25,7 @@ An implementation of `LimitedMemoryBroyden` with reseting and line search.
 end
 
 function LimitedMemoryBroyden(; max_resets::Int = 3, linesearch = LineSearch(),
-    threshold::Int = 10, reset_tolerance = nothing)
+    threshold::Int = 27, reset_tolerance = nothing)
     linesearch = linesearch isa LineSearch ? linesearch : LineSearch(; method = linesearch)
     return LimitedMemoryBroyden(max_resets, threshold, linesearch, reset_tolerance)
 end
@@ -134,6 +134,7 @@ function perform_step!(cache::LimitedMemoryBroydenCache{true})
         cache.resets += 1
         cache.du .= cache.fu
     else
+        cache.du .*= -1
         idx = min(cache.iterations_since_reset, size(cache.U, 1))
         U_part = selectdim(cache.U, 1, 1:idx)
         Vᵀ_part = selectdim(cache.Vᵀ, 2, 1:idx)
@@ -193,6 +194,7 @@ function perform_step!(cache::LimitedMemoryBroydenCache{false})
         cache.resets += 1
         cache.du = cache.fu
     else
+        cache.du = -cache.du
         idx = min(cache.iterations_since_reset, size(cache.U, 1))
         U_part = selectdim(cache.U, 1, 1:idx)
         Vᵀ_part = selectdim(cache.Vᵀ, 2, 1:idx)

src/linesearch.jl

@@ -162,10 +162,7 @@ function perform_linesearch!(cache::LineSearchesJLCache, u, du)
 
     ϕ₀, dϕ₀ = ϕdϕ(zero(eltype(u)))
 
-    # This case is sometimes possible for large optimization problems
-    dϕ₀ ≥ 0 && return cache.α
-
-    return first(cache.ls.method(ϕ, cache.dϕ(u, du), cache.ϕdϕ(u, du), cache.α, ϕ₀, dϕ₀))
+    return first(cache.ls.method(ϕ, dϕ, ϕdϕ, cache.α, ϕ₀, dϕ₀))
 end
 
 """
@@ -252,11 +249,11 @@ function perform_linesearch!(cache::LiFukushimaLineSearchCache{iip}, u, du) wher
             λ₁, λ₂ = λ₂, β * λ₂
 
             if iip
-                cache.u_cache .= u .- λ₂ .* du
+                cache.u_cache .= u .+ λ₂ .* du
                 cache.f(cache.fu_cache, cache.u_cache, cache.p)
                 fxλp_norm = norm(cache.fu_cache, 2)
             else
-                fxλp_norm = norm(cache.f(u .- λ₂ .* du, cache.p), 2)
+                fxλp_norm = norm(cache.f(u .+ λ₂ .* du, cache.p), 2)
             end
 
             nan_converged = isfinite(fxλp_norm)

test/23_test_problems.jl

@@ -83,32 +83,20 @@ end
 
 # Broyden and Klement Tests are quite flaky and failure seems to be platform dependent
 # needs additional investigation before we can enable them
-#=
 @testset "GeneralBroyden 23 Test Problems" begin
-    alg_ops = (GeneralBroyden(),
-        GeneralBroyden(; linesearch = LiFukushimaLineSearch(; beta = 0.1)),
-        GeneralBroyden(; linesearch = BackTracking()))
+    alg_ops = (GeneralBroyden(),)
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
-    broken_tests[alg_ops[1]] = [1, 3, 4, 5, 6, 11, 12, 13, 14, 21]
-    broken_tests[alg_ops[2]] = [1, 2, 3, 4, 5, 6, 9, 11, 13, 22]
-    broken_tests[alg_ops[3]] = [1, 2, 4, 5, 6, 11, 12, 13, 14, 21]
+    broken_tests[alg_ops[1]] = [1, 2, 4, 5, 6, 11, 12, 13, 14]
 
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
 @testset "GeneralKlement 23 Test Problems" begin
-    alg_ops = (GeneralKlement(),
-        GeneralKlement(; linesearch = BackTracking()),
-        GeneralKlement(; linesearch = HagerZhang()))
+    alg_ops = (GeneralKlement(),)
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
     broken_tests[alg_ops[1]] = [1, 2, 4, 5, 6, 7, 11, 13, 22]
-    broken_tests[alg_ops[2]] = [1, 2, 4, 5, 6, 7, 11, 12, 13, 22]
-    broken_tests[alg_ops[3]] = [1, 2, 4, 5, 6, 8, 11, 12, 13, 22]
 
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
-=#
-
-# NOTE: Not adding LimitedMemoryBroyden here since it fails on most of the preoblems