Skip to content

Commit e413c85

Browse files
committed
add deprecation path for alias_u0 in __init and __solve
1 parent 2cb8d3f commit e413c85

File tree

16 files changed

+47
-2
lines changed

16 files changed

+47
-2
lines changed

ext/NonlinearSolveFixedPointAccelerationExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ function SciMLBase.__solve(
1111
abstol = nothing, maxiters = 1000, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false),
1212
show_trace::Val = Val(false), termination_condition = nothing, kwargs...
1313
)
14+
if haskey(kwargs, :alias_u0)
15+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
16+
end
1417
alias_u0 = alias.alias_u0
1518
NonlinearSolveBase.assert_extension_supported_termination_condition(
1619
termination_condition, alg

ext/NonlinearSolveNLSolversExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ function SciMLBase.__solve(
1616
abstol = nothing, reltol = nothing, maxiters = 1000, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false),
1717
termination_condition = nothing, kwargs...
1818
)
19+
if haskey(kwargs, :alias_u0)
20+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
21+
end
1922
alias_u0 = alias.alias_u0
2023
NonlinearSolveBase.assert_extension_supported_termination_condition(
2124
termination_condition, alg

ext/NonlinearSolveNLsolveExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ function SciMLBase.__solve(
1313
termination_condition = nothing, trace_level = TraceMinimal(),
1414
store_trace::Val = Val(false), show_trace::Val = Val(false), kwargs...
1515
)
16+
if haskey(kwargs, :alias_u0)
17+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
18+
end
1619
alias_u0 = alias.alias_u0
1720
NonlinearSolveBase.assert_extension_supported_termination_condition(
1821
termination_condition, alg

ext/NonlinearSolvePETScExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ function SciMLBase.__solve(
1717
maxiters = 1000, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false), termination_condition = nothing,
1818
show_trace::Val = Val(false), kwargs...
1919
)
20+
if haskey(kwargs, :alias_u0)
21+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
22+
end
2023
alias_u0 = alias.alias_u0
2124
# XXX: https://petsc.org/release/manualpages/SNES/SNESSetConvergenceTest/
2225
NonlinearSolveBase.assert_extension_supported_termination_condition(

ext/NonlinearSolveSIAMFANLEquationsExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ function SciMLBase.__solve(
4242
abstol = nothing, reltol = nothing, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false), maxiters = 1000,
4343
termination_condition = nothing, show_trace = Val(false), kwargs...
4444
)
45+
if haskey(kwargs, :alias_u0)
46+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
47+
end
4548
alias_u0 = alias.alias_u0
4649
NonlinearSolveBase.assert_extension_supported_termination_condition(
4750
termination_condition, alg

ext/NonlinearSolveSpeedMappingExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ function SciMLBase.__solve(
1212
maxtime = nothing, store_trace::Val = Val(false),
1313
termination_condition = nothing, kwargs...
1414
)
15+
if haskey(kwargs, :alias_u0)
16+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
17+
end
1518
alias_u0 = alias.alias_u0
1619
NonlinearSolveBase.assert_extension_supported_termination_condition(
1720
termination_condition, alg

lib/NonlinearSolveBase/src/polyalg.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,9 @@ function SciMLBase.__init(
120120
internalnorm::IN = L2_NORM, alias = NonlinearAliasSpecifier(alias_u0 = false), verbose = true,
121121
initializealg = NonlinearSolveDefaultInit(), kwargs...
122122
) where {IN}
123+
if haskey(kwargs, :alias_u0)
124+
alias = NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
125+
end
123126
alias_u0 = alias.alias_u0
124127
if alias_u0 && !ArrayInterface.ismutable(prob.u0)
125128
verbose && @warn "`alias_u0` has been set to `true`, but `u0` is \

lib/NonlinearSolveBase/src/solve.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ function solve(prob::AbstractNonlinearProblem, args...; sensealg = nothing,
5959
elseif haskey(prob.kwargs, :alias) && prob.kwargs[:alias] isa Bool
6060
NonlinearAliasSpecifier(alias = prob.kwargs[:alias])
6161
elseif haskey(kwargs, :alias_u0)
62-
@warn lazy"The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
62+
@warn "The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
6363
NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
6464
elseif haskey(prob.kwargs, :alias_u0)
65-
@warn lazy"The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
65+
@warn "The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
6666
NonlinearAliasSpecifier(alias_u0 = prob.kwargs[:alias_u0])
6767
else
6868
NonlinearAliasSpecifier(alias_u0 = false)

lib/NonlinearSolveFirstOrder/src/solve.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,9 @@ function SciMLBase.__init(
132132
termination_condition = nothing, internalnorm::IN = L2_NORM,
133133
linsolve_kwargs = (;), initializealg = NonlinearSolveBase.NonlinearSolveDefaultInit(), kwargs...
134134
) where {IN}
135+
if haskey(kwargs, :alias_u0)
136+
alias = NonlinearSolveBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
137+
end
135138
alias_u0 = alias.alias_u0
136139
@set! alg.autodiff = NonlinearSolveBase.select_jacobian_autodiff(prob, alg.autodiff)
137140
provided_jvp_autodiff = alg.jvp_autodiff !== nothing

lib/NonlinearSolveQuasiNewton/src/solve.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@ function SciMLBase.__init(
151151
internalnorm::F = L2_NORM, initializealg = NonlinearSolveBase.NonlinearSolveDefaultInit(),
152152
kwargs...
153153
) where {F}
154+
if haskey(kwargs, :alias_u0)
155+
alias = NonlinearSolveBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
156+
end
154157
alias_u0 = alias.alias_u0
155158
timer = get_timer_output()
156159
@static_timeit timer "cache construction" begin

0 commit comments

Comments
 (0)