redundant linsolve kwargs

Author: jClugstor

lib/NonlinearSolveBase/src/descent/damped_newton.jl

@@ -135,16 +135,6 @@ function InternalAPI.init(
         A, b = Utils.maybe_symmetric(J_damped), Utils.safe_vec(Jᵀfu)
         rhs_cache = nothing
     end
-    
-    if !haskey(linsolve_kwargs, :verbose)
-        if kwargs[:verbose].linear_verbosity isa Verbosity.Type
-            linsolve_kwargs = merge(
-                linsolve_kwargs, (; verbose = LinearVerbosity(kwargs[:verbose])))
-        else
-            linsolve_kwargs = merge(
-                linsolve_kwargs, (; verbose = kwargs[:verbose].linear_verbosity))
-        end
-    end
 
     lincache = construct_linear_solver(
         alg, alg.linsolve, A, b, Utils.safe_vec(u);

lib/NonlinearSolveBase/src/descent/newton.jl

@@ -36,16 +36,6 @@ function InternalAPI.init(
         @bb δu_ = similar(u)
     end
 
-    if !haskey(linsolve_kwargs, :verbose)
-        if kwargs[:verbose].linear_verbosity isa Verbosity.Type
-            linsolve_kwargs = merge(
-                linsolve_kwargs, (; verbose = LinearVerbosity(kwargs[:verbose])))
-        else
-            linsolve_kwargs = merge(
-                linsolve_kwargs, (; verbose = kwargs[:verbose].linear_verbosity))
-        end
-    end
-
     if Utils.unwrap_val(pre_inverted)
         lincache = nothing
     else
@@ -54,7 +44,6 @@ function InternalAPI.init(
             stats, abstol, reltol, linsolve_kwargs...
         )
     end
-    #Main.@infiltrate
     return NewtonDescentCache(
         δu, δus, lincache, nothing, nothing, timer, pre_inverted, Val(false)
     )
@@ -84,16 +73,6 @@ function InternalAPI.init(
         A, b = J, Utils.safe_vec(fu)
     end
 
-    if !haskey(linsolve_kwargs, :verbose)
-        if kwargs[:verbose].linear_verbosity isa Verbosity.Type
-            linsolve_kwargs = merge(
-                linsolve_kwargs, (; verbose=LinearVerbosity(kwargs[:verbose])))
-        else
-            linsolve_kwargs = merge(
-                linsolve_kwargs, (; verbose=kwargs[:verbose].linear_verbosity))
-        end
-    end
-
     lincache = construct_linear_solver(
         alg, alg.linsolve, A, b, Utils.safe_vec(u);
         stats, abstol, reltol, linsolve_kwargs...

lib/NonlinearSolveBase/src/descent/steepest.jl

@@ -37,17 +37,6 @@ function InternalAPI.init(
         @bb δu_ = similar(u)
     end
     if Utils.unwrap_val(pre_inverted)
-
-        if !haskey(linsolve_kwargs, :verbose)
-            if kwargs[:verbose].linear_verbosity isa Verbosity.Type
-                linsolve_kwargs = merge(
-                    linsolve_kwargs, (; verbose = LinearVerbosity(kwargs[:verbose])))
-            else
-                linsolve_kwargs = merge(
-                    linsolve_kwargs, (; verbose = kwargs[:verbose].linear_verbosity))
-            end
-        end
-
         lincache = construct_linear_solver(
             alg, alg.linsolve, transpose(J), Utils.safe_vec(fu), Utils.safe_vec(u);
             stats, abstol, reltol, linsolve_kwargs...