support ForwardDiff 1.0 #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
force-pushed
the
os/ForwardDiff1.0
branch
from
c886bf6 to
8c60043
Compare
|
After a bunch of work, tests now pass locally! Let's go ahead with this. |
|
@avik-pal Among the fake failures (windows-latest and downgrade), there do seem to be a real SimpleNonlinearSolve failures https://github.com/SciML/NonlinearSolve.jl/actions/runs/14230300699/job/39879379343?pr=561. however, they seem to be the same as in #566, https://github.com/SciML/NonlinearSolve.jl/actions/runs/14180225226/job/39724441050?pr=566 so I'm not sure what's going on here. Any ideas? |
oscardssmith
force-pushed
the
os/ForwardDiff1.0
branch
from
8c60043 to
cfed6b1
Compare
|
does anyone understand the Edit: traced to JuliaPackaging/Yggdrasil#10924 |
oscardssmith
force-pushed
the
os/ForwardDiff1.0
branch
from
cfed6b1 to
080696a
Compare
|
CI failures at this point are all unrelated. Merging. |
|
you're doing the releases? |
|
yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.