fix: failing tests #580
Merged
fix: failing tests #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fix_tests_simplenonlinearsolve
branch
from
8f3bb7d to
c297909
Compare
avik-pal
force-pushed
the
ap/fix_tests_simplenonlinearsolve
branch
from
c297909 to
2142c79
Compare
|
https://github.com/SciML/NonlinearSolve.jl/actions/runs/14544669588/job/40808434530?pr=580 is the only failing one atm and I am not sure why |
| prob, SimpleBroyden(; alg.linesearch), args...; | ||
| abstol, reltol, maxiters, termination_condition, kwargs... | ||
| ) | ||
| return Utils.nonlinear_solution_new_alg(sol, alg) |
There was a problem hiding this comment.
won't this lead to type stability issues?
There was a problem hiding this comment.
no this will fix it. we need to use simplebroyden for the solve process. But we ensure all branches mark the returned alg as simplelbroyden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.