From 0d0f19a389e44d7d81534f90ac88c63e07ef6d35 Mon Sep 17 00:00:00 2001 From: Avik Pal Date: Wed, 25 Sep 2024 17:12:47 -0400 Subject: [PATCH 1/2] fix: DI now works with ReverseDiff --- lib/SciMLJacobianOperators/Project.toml | 2 +- lib/SciMLJacobianOperators/test/core_tests.jl | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/SciMLJacobianOperators/Project.toml b/lib/SciMLJacobianOperators/Project.toml index 5209241bc..900f70e35 100644 --- a/lib/SciMLJacobianOperators/Project.toml +++ b/lib/SciMLJacobianOperators/Project.toml @@ -19,7 +19,7 @@ ADTypes = "1.8.1" Aqua = "0.8.7" ConcreteStructs = "0.2.3" ConstructionBase = "1.5" -DifferentiationInterface = "0.6" +DifferentiationInterface = "0.6.1" Enzyme = "0.12, 0.13" EnzymeCore = "0.7, 0.8" ExplicitImports = "1.9.0" diff --git a/lib/SciMLJacobianOperators/test/core_tests.jl b/lib/SciMLJacobianOperators/test/core_tests.jl index 6fb024a0c..e3b595221 100644 --- a/lib/SciMLJacobianOperators/test/core_tests.jl +++ b/lib/SciMLJacobianOperators/test/core_tests.jl @@ -7,7 +7,7 @@ AutoEnzyme(), AutoEnzyme(; mode = Enzyme.Reverse), AutoZygote(), - # AutoReverseDiff(), # FIXME: https://github.com/gdalle/DifferentiationInterface.jl/issues/503 + AutoReverseDiff(), AutoTracker(), AutoFiniteDiff() ] @@ -91,7 +91,7 @@ end reverse_ADs = [ AutoEnzyme(), AutoEnzyme(; mode = Enzyme.Reverse), - # AutoReverseDiff(), # FIXME: https://github.com/gdalle/DifferentiationInterface.jl/issues/503 + AutoReverseDiff(), AutoFiniteDiff() ] @@ -182,7 +182,7 @@ end AutoEnzyme(; mode = Enzyme.Reverse), AutoZygote(), AutoTracker(), - # AutoReverseDiff(), # FIXME: https://github.com/gdalle/DifferentiationInterface.jl/issues/503 + AutoReverseDiff(), AutoFiniteDiff() ] From c9f3607ef77fa3d5ed58d35aa10e84626bc02dc9 Mon Sep 17 00:00:00 2001 From: Avik Pal Date: Wed, 25 Sep 2024 17:17:57 -0400 Subject: [PATCH 2/2] fix: remove stale dep --- lib/SciMLJacobianOperators/Project.toml | 2 -- lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/SciMLJacobianOperators/Project.toml b/lib/SciMLJacobianOperators/Project.toml index 900f70e35..73ee5a55d 100644 --- a/lib/SciMLJacobianOperators/Project.toml +++ b/lib/SciMLJacobianOperators/Project.toml @@ -8,7 +8,6 @@ ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b" ConcreteStructs = "2569d6c7-a4a2-43d3-a901-331e8e4be471" ConstructionBase = "187b0558-2788-49d3-abe0-74a17ed4e7c9" DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63" -EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869" FastClosures = "9aa1b823-49e4-5ca5-8b0f-3971ec8bab6a" LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462" @@ -21,7 +20,6 @@ ConcreteStructs = "0.2.3" ConstructionBase = "1.5" DifferentiationInterface = "0.6.1" Enzyme = "0.12, 0.13" -EnzymeCore = "0.7, 0.8" ExplicitImports = "1.9.0" FastClosures = "0.3.2" FiniteDiff = "2.24.0" diff --git a/lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl b/lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl index e807e983c..bb7a60441 100644 --- a/lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl +++ b/lib/SciMLJacobianOperators/src/SciMLJacobianOperators.jl @@ -4,7 +4,6 @@ using ADTypes: ADTypes, AutoSparse using ConcreteStructs: @concrete using ConstructionBase: ConstructionBase using DifferentiationInterface: DifferentiationInterface, Constant -using EnzymeCore: EnzymeCore using FastClosures: @closure using LinearAlgebra: LinearAlgebra using SciMLBase: SciMLBase, AbstractNonlinearProblem, AbstractNonlinearFunction