From 85e5c04646210f214bc0652b2cf89b3cb9684972 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 19 Mar 2025 11:30:36 -0100 Subject: [PATCH 1/5] Add misc test group to NonlinearSolve CI to run QA tests --- .github/workflows/CI_NonlinearSolve.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/CI_NonlinearSolve.yml b/.github/workflows/CI_NonlinearSolve.yml index 3be961848..8dc374550 100644 --- a/.github/workflows/CI_NonlinearSolve.yml +++ b/.github/workflows/CI_NonlinearSolve.yml @@ -37,6 +37,7 @@ jobs: - core - downstream - wrappers + - misc version: - "1.10" - "1" @@ -95,6 +96,7 @@ jobs: - core - downstream - wrappers + - misc steps: - uses: actions/checkout@v4 - uses: julia-actions/setup-julia@v2 From a826a45e91eb5c0c213d9dbf26aa4a2a25224313 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 19 Mar 2025 12:26:06 -0100 Subject: [PATCH 2/5] Update NonlinearSolve.jl --- src/NonlinearSolve.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NonlinearSolve.jl b/src/NonlinearSolve.jl index a1b759011..394b17324 100644 --- a/src/NonlinearSolve.jl +++ b/src/NonlinearSolve.jl @@ -7,7 +7,7 @@ using FastClosures: @closure using ADTypes: ADTypes using ArrayInterface: ArrayInterface -using CommonSolve: CommonSolve, solve, solve! +using CommonSolve: CommonSolve, init, solve, solve! using DiffEqBase: DiffEqBase # Needed for `init` / `solve` dispatches using LinearAlgebra: LinearAlgebra, norm using LineSearch: BackTracking From 55f142dd93c001c379b33fa91c231089d6c801fb Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 19 Mar 2025 12:27:40 -0100 Subject: [PATCH 3/5] Update NonlinearSolveNLSolversExt.jl --- ext/NonlinearSolveNLSolversExt.jl | 1 - 1 file changed, 1 deletion(-) diff --git a/ext/NonlinearSolveNLSolversExt.jl b/ext/NonlinearSolveNLSolversExt.jl index 95aa0c8c3..e4e2206af 100644 --- a/ext/NonlinearSolveNLSolversExt.jl +++ b/ext/NonlinearSolveNLSolversExt.jl @@ -1,6 +1,5 @@ module NonlinearSolveNLSolversExt -using ADTypes: ADTypes, AutoFiniteDiff, AutoForwardDiff, AutoPolyesterForwardDiff using DifferentiationInterface: DifferentiationInterface, Constant using FastClosures: @closure From 2ba4774e0148d43d13cb5485845a39e028f7e88b Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 19 Mar 2025 13:59:32 -0100 Subject: [PATCH 4/5] Update NonlinearSolve.jl --- src/NonlinearSolve.jl | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/NonlinearSolve.jl b/src/NonlinearSolve.jl index 394b17324..c5c031b7d 100644 --- a/src/NonlinearSolve.jl +++ b/src/NonlinearSolve.jl @@ -9,15 +9,12 @@ using ADTypes: ADTypes using ArrayInterface: ArrayInterface using CommonSolve: CommonSolve, init, solve, solve! using DiffEqBase: DiffEqBase # Needed for `init` / `solve` dispatches -using LinearAlgebra: LinearAlgebra, norm +using LinearAlgebra: LinearAlgebra using LineSearch: BackTracking -using NonlinearSolveBase: NonlinearSolveBase, InternalAPI, AbstractNonlinearSolveAlgorithm, - AbstractNonlinearSolveCache, Utils, L2_NORM, - enable_timer_outputs, disable_timer_outputs, +using NonlinearSolveBase: NonlinearSolveBase, AbstractNonlinearSolveAlgorithm, NonlinearSolvePolyAlgorithm, pickchunksize -using Preferences: set_preferences! -using SciMLBase: SciMLBase, NLStats, ReturnCode, AbstractNonlinearProblem, +using SciMLBase: SciMLBase, ReturnCode, AbstractNonlinearProblem, NonlinearFunction, NonlinearProblem, NonlinearLeastSquaresProblem, NoSpecialize using SymbolicIndexingInterface: SymbolicIndexingInterface From b1600989659165ec5a6a46ce73310c12249a6e61 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 19 Mar 2025 14:58:52 -0100 Subject: [PATCH 5/5] Update qa_tests.jl --- test/qa_tests.jl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/qa_tests.jl b/test/qa_tests.jl index 65f0f7947..db7dcc073 100644 --- a/test/qa_tests.jl +++ b/test/qa_tests.jl @@ -1,8 +1,10 @@ @testitem "Aqua" tags=[:misc] begin using NonlinearSolve, SimpleNonlinearSolve, Aqua - Aqua.test_all(NonlinearSolve; ambiguities = false, piracies = false) + Aqua.test_all(NonlinearSolve; ambiguities = false, piracies = false, stale_deps = false, deps_compat = false) Aqua.test_ambiguities(NonlinearSolve; recursive = false) + Aqua.test_stale_deps(SimpleNonlinearSolve; ignore = [:SciMLJacobianOperators]) + Aqua.test_deps_compat(SimpleNonlinearSolve; ignore = [:SciMLJacobianOperators]) Aqua.test_piracies(NonlinearSolve, treat_as_own = [ NonlinearProblem, NonlinearLeastSquaresProblem, SciMLBase.AbstractNonlinearProblem,