From c7aef87e7cb98cd92b6ac202b964cba65b1a172a Mon Sep 17 00:00:00 2001 From: Oscar Smith Date: Tue, 15 Apr 2025 10:45:33 -0400 Subject: [PATCH] remove true_jacobian Broyden from default alg This method is unlikely to be much better than normal Broyden or Klement and requires a pseudoinverse which is really bad for sparse jacobians. As such, this PR removes it when we aren't preferring the Simple algs --- src/poly_algs.jl | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/poly_algs.jl b/src/poly_algs.jl index 3b13ba84f..875bf7e40 100644 --- a/src/poly_algs.jl +++ b/src/poly_algs.jl @@ -72,7 +72,6 @@ function FastShortcutNonlinearPolyalg( if T <: Complex algs = ( Broyden(; autodiff), - Broyden(; init_jacobian = Val(:true_jacobian), autodiff), Klement(; linsolve, autodiff), NewtonRaphson(; common_kwargs...) ) @@ -81,7 +80,6 @@ function FastShortcutNonlinearPolyalg( start_index = u0_len !== nothing ? (u0_len ≤ 25 ? 4 : 1) : 1 algs = ( Broyden(; autodiff), - Broyden(; init_jacobian = Val(:true_jacobian), autodiff), Klement(; linsolve, autodiff), NewtonRaphson(; common_kwargs...), NewtonRaphson(; common_kwargs..., linesearch = BackTracking()),