Fix SCC residuals transfer for linear problems #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when using the SCC algorithm with linear problems, residuals were not computed and passed as nothing, resulting in a vector with nothing values in the solution object. This fix checks if sol.resid is nothing (which it often is for LinearSolution) and computes residuals using the formula `resid = A*u - b` when needed, then properly transfers them to the solution object. Fixes SciML#706 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ChrisRackauckas-Claude
force-pushed
the
fix-scc-residuals
branch
from
44a3690 to
21df2f1
Compare
|
Updated the fix based on feedback. The LinearSolution object does have a field, but it's often by default. The updated fix now checks if is and only computes the residuals manually when needed using . This is more robust and handles both cases where the linear solver might or might not provide residuals. |
|
Updated the fix based on feedback. The LinearSolution object does have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resid = A*u - bDetails
Previously, when solving SCC problems that contained LinearProblem components, the residuals were being passed as
nothingin thebuild_linear_solutioncall. This resulted in a solution object withnothingvalues in the residuals array.The fix computes the residuals for linear problems using the formula
resid = A*u - bafter solving, and passes them tobuild_linear_solution.Test plan
"SCC Residuals Transfer"that verifies:nothingnothingvalues exist in the residuals array🤖 Generated with Claude Code