Skip to content

Fix Tracing in docs example #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Fix Tracing in docs example #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/NonlinearSolveBase/src/tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ function update_trace!(
entry = if trace.trace_level.trace_mode isa Val{:minimal}
NonlinearSolveTraceEntry(trace.prob, iter, fu, δu .* α, missing, missing)
else
J = convert(AbstractArray, J)
if !isnothing(J)
J = convert(AbstractArray, J)
end
if trace.trace_level.trace_mode isa Val{:condition_number}
NonlinearSolveTraceEntry(trace.prob, iter, fu, δu .* α, J, missing)
else
Expand All @@ -220,7 +222,7 @@ end
function update_trace!(cache, α = true; uses_jac_inverse = Val(false))
trace = Utils.safe_getproperty(cache, Val(:trace))
trace === missing && return nothing

J = Utils.safe_getproperty(cache, Val(:J))
du = SciMLBase.get_du(cache)
if J === missing
Expand Down
Loading