Skip to content

Commit 2bce34b

Browse files
Follow DiffEqBase pattern: import solve interface from SciMLBase
Match DiffEqBase style by importing all solve interface functions from SciMLBase rather than directly from CommonSolve. SciMLBase already imports from CommonSolve and exports these functions, so all packages in the ecosystem should import from SciMLBase for consistency. Changes: - Remove CommonSolve as a direct dependency - Import solve, init, solve!, __init, __solve from SciMLBase - Keep all other SciMLBase imports organized together This matches exactly how DiffEqBase handles the solve interface. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 29388ff commit 2bce34b

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

lib/OptimizationBase/Project.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ version = "3.0.0"
66
[deps]
77
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
88
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
9-
CommonSolve = "38540f10-b2f7-11e9-35d8-d573e4eb0ff2"
109
DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
1110
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
1211
FastClosures = "9aa1b823-49e4-5ca5-8b0f-3971ec8bab6a"
@@ -43,7 +42,6 @@ OptimizationZygoteExt = "Zygote"
4342
[compat]
4443
ADTypes = "1.9"
4544
ArrayInterface = "7.6"
46-
CommonSolve = "0.2"
4745
DifferentiationInterface = "0.7"
4846
DocStringExtensions = "0.9"
4947
Enzyme = "0.13.2"

lib/OptimizationBase/src/OptimizationBase.jl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,15 @@ using Reexport
55
@reexport using SciMLBase, ADTypes
66

77
using ArrayInterface, Base.Iterators, SparseArrays, LinearAlgebra
8-
import CommonSolve: init, solve, solve!
9-
import SciMLBase: OptimizationProblem,
8+
import SciMLBase: solve, init, solve!, __init, __solve,
9+
OptimizationProblem,
1010
OptimizationFunction, ObjSense,
1111
MaxSense, MinSense, OptimizationStats,
1212
allowsbounds, requiresbounds,
1313
allowsconstraints, requiresconstraints,
1414
allowscallback, requiresgradient,
1515
requireshessian, requiresconsjac,
16-
requiresconshess, supports_opt_cache_interface,
17-
__init, __solve
16+
requiresconshess, supports_opt_cache_interface
1817
export ObjSense, MaxSense, MinSense
1918
export allowsbounds, requiresbounds, allowsconstraints, requiresconstraints,
2019
allowscallback, requiresgradient, requireshessian,

0 commit comments

Comments
 (0)