Skip to content

Commit 71fa9e1

Browse files
committed
fix solveup typos
1 parent 949b8c6 commit 71fa9e1

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

lib/OptimizationBase/src/solve.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,8 @@ function solve_up(prob::SciMLBase.OptimizationProblem, sensealg, u0, p, args...;
236236
kwargs...)
237237
alg = extract_opt_alg(args, kwargs, has_kwargs(prob) ? prob.kwargs : kwargs)
238238
_prob = get_concrete_problem(prob; u0 = u0, p = p, kwargs...)
239-
if length(args) < 1
240-
solve_call(_prob, alg, Base.tails(args)..., kwargs...)
239+
if length(args) > 1
240+
solve_call(_prob, alg, Base.tail(args)..., kwargs...)
241241
else
242242
solve_call(_prob, alg; kwargs...)
243243
end

lib/OptimizationMultistartOptimization/test/runtests.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,13 @@ using Test, ReverseDiff
1212
OptimizationNLopt.Opt(:LD_LBFGS, 2))
1313
@test 10 * sol.objective < l1
1414
end
15+
16+
rosenbrock(x, p) = (p[1] - x[1])^2 + p[2] * (x[2] - x[1]^2)^2
17+
x0 = zeros(2)
18+
_p = [1.0, 100.0]
19+
l1 = rosenbrock(x0, _p)
20+
f = OptimizationFunction(rosenbrock, OptimizationBase.AutoForwardDiff())
21+
prob = OptimizationBase.OptimizationProblem(f, x0, _p, lb = [-1.0, -1.0], ub = [1.5, 1.5])
22+
sol = solve(prob, OptimizationMultistartOptimization.TikTak(100),
23+
OptimizationNLopt.Opt(:LD_LBFGS, 2))
24+
@test 10 * sol.objective < l1

0 commit comments

Comments
 (0)