Skip to content

Commit b0f2a3f

Browse files
authored
fix: match iterations count in Sophia
1 parent 68f7a0b commit b0f2a3f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/sophia.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
7575
gₜ = zero(θ)
7676
mₜ = zero(θ)
7777
hₜ = zero(θ)
78-
for _ in 1:maxiters
78+
for epoch in 1:maxiters
7979
for (i, d) in enumerate(data)
8080
if cache.f.fg !== nothing && dataiterate
8181
x = cache.f.fg(gₜ, θ, d)
@@ -88,7 +88,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
8888
cache.f.grad(gₜ, θ)
8989
x = cache.f(θ)
9090
end
91-
opt_state = Optimization.OptimizationState(; iter = i,
91+
opt_state = Optimization.OptimizationState(; iter = i + (epoch - 1) * length(data),
9292
u = θ,
9393
objective = first(x),
9494
grad = gₜ,

0 commit comments

Comments
 (0)